[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Bug(?) fix patch of khtml_settings.cc
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2001-03-11 10:57:20
[Download RAW message or body]

Hello,

The patch which I attached fixes the bug that configuration of font
is not reflected with KMail. (CVS of 09/03)

Please review. (Sorry, I'm diffident of this patch.)



I have a question.

In the 412 line of khtml_settings.cc :
for (int i = 0; it != end; it++ ) {
  m_fontSizes[ i++ ] = *it; // 421 line
  kdDebug() << "m_fontSizes:" << m_fontSizes[ i ] 
            << "  *it:" << *it << endl;
}

Debug message :
kmail: m_fontSizes:8  *it:13
kmail: m_fontSizes:9  *it:14
kmail: m_fontSizes:10  *it:15
kmail: m_fontSizes:12  *it:16
kmail: m_fontSizes:14  *it:18
kmail: m_fontSizes:16  *it:20
kmail: m_fontSizes:24  *it:22

digit value of m_fontSizes[ i ] does not agree with *it.


When I change the 411 line and 412 line of khtml_settings.cc in

for (int i = 0; it != end; it++ , i++) {
  m_fontSizes[ i ] = *it;
  kdDebug() << "m_fontSizes:" << m_fontSizes[ i ] 
            << "  *it:" << *it << endl;
}

Debug message :
kmail: m_fontSizes:13  *it:13
kmail: m_fontSizes:14  *it:14
kmail: m_fontSizes:15  *it:15
kmail: m_fontSizes:16  *it:16
kmail: m_fontSizes:18  *it:18
kmail: m_fontSizes:20  *it:20
kmail: m_fontSizes:22  *it:22

digit value of m_fontSizes[ i ] agree with *it.


There is not relational in configuration of font with KMali.
Is this a bug?

Thank you.






["kdelibs-khtml_settings-20010311.diff" (text/plain)]

diff -ur kdelibs.orig/khtml/khtml_settings.cc kdelibs/khtml/khtml_settings.cc
--- kdelibs.orig/khtml/khtml_settings.cc	Sun Mar 11 19:02:01 2001
+++ kdelibs/khtml/khtml_settings.cc	Sun Mar 11 19:04:29 2001
@@ -527,7 +527,7 @@
 {
     m_charset = c;
     availFamilies = KGlobal::charsets()->availableFamilies( m_charset ).join(",");
-    resetFontSizes();
+    //resetFontSizes();
 }
 
 void KHTMLSettings::setScript( QFont::CharSet c )

>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]