[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch Fix? for bug 20393
From:       Cullmann Christoph <crossfire () babylon2k ! de>
Date:       2001-02-14 15:13:46
[Download RAW message or body]

Sorry, doesn't work on my system, KWrite (Kant) crashs like before.

cu
Christoph

kant.sourceforge.net

Am Mittwoch, 14. Februar 2001 15:18 schrieb Scott Manson:
> On Wednesday 14 February 2001 05:07 am, jowenn@bigfoot.com wrote:
> > I didn't have much time for investigation, but it seams, after a view is
> > deleted it stays in the
> > the list somehow. If I insert a view and delete it, in the newUndo()
> > function of the document it
> > is  still referenced over the m_view list.
> >
> > Kind regards
> > Joseph
> > Wenninger
>
> I don't know if this is pertinant but does anyone know
> why
> bool KWrite::isLastView() {
>   return kWriteDoc->isLastView(1);
> }
> and (in destructor of KWrite)
> if ( kWriteDoc->isLastView(0) && !kWriteDoc->isSingleViewMode() )
>
> this is definition of isLastView
> bool KWriteDoc::isLastView(int numViews) {
>   return ((int) views.count() == numViews);
> }
> The different isLastView parameters seems to me to be funky
> Can we have a document w/o a view? I would seem to think so
> conversely can we have a view w/o a document?
>
> it seems that m_bSingleViewMode is only set once to False
> m_bSingleViewMode = bSingleViewMode
> (in KWriteDoc constructor around line 124 in kwdoc.cpp )
> and around line 164 it is used like so
> if ( m_bSingleViewMode )   {
>     KTextEditor::View *view = createView( parentWidget, widgetName );
> Should we add something like
>     m_bSingleViewMode=views.count() == 1;  // should it be 0 or 1
> I am puzzled here If we have 0 views is it a SingleViewMode?
>
> I tried this hack and can't reproduce the crash while w/o it does
> can someone apply/test this patch to see if fixes the bug.

["kwdoc.diff" (text/plain)]


>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]