[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] [KHTML} Fix for www.time.com crash.
From:       Michael Bedy <mjbedy () mediaone ! net>
Date:       2001-01-11 7:43:59
[Download RAW message or body]

The attached patch fixes a crash caused by deleting javascript stuff,
then trying to call it from onUnload. Doing things in the other order
seemed more appropriate.

   - Mike


["khtml.diff" (TEXT/PLAIN)]

Index: khtml_part.cpp
===================================================================
RCS file: /home/projects/kdecvs/cvsroot/kdelibs/khtml/khtml_part.cpp,v
retrieving revision 1.355
diff -u -r1.355 khtml_part.cpp
--- khtml_part.cpp	2001/01/08 18:01:30	1.355
+++ khtml_part.cpp	2001/01/11 07:39:39
@@ -986,8 +986,6 @@
 
   d->m_mousePressNode = DOM::Node();
 
-  if ( d->m_jscript )
-    d->m_jscript->clear();
 
   if ( d->m_doc )
   {
@@ -996,6 +994,10 @@
     d->m_doc->deref();
   }
   d->m_doc = 0;
+
+  // Moving past doc so that onUnload works.
+  if ( d->m_jscript )
+    d->m_jscript->clear();
 
   delete d->m_decoder;
 

>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]