From kde-devel Tue Jan 09 18:43:05 2001 From: Anders Lund Date: Tue, 09 Jan 2001 18:43:05 +0000 To: kde-devel Subject: Re: RFC: Moving some panel and tray applets from QPopupMenu to KPopupMenu X-MARC-Message: https://marc.info/?l=kde-devel&m=97906632811417 I read malthes message in the digest version, so it's not quoted: --------------------------------------------------- Message: 1 charset="iso-8859-1" From: Malte.Starostik@t-online.de (Malte Starostik) To: kde-devel@kde.org Subject: RFC: Moving some panel and tray applets from QPopupMenu to KPopupMenu Date: Tue, 9 Jan 2001 12:06:39 +0100 Reply-To: kde-devel@master.kde.org Hi, just compared some of the kicker and systray applets context menus and noticed that some use QPopupMenu, others use KPopupMenu, some of the latter with, some without a title, some titles with, some without icon in the title. I changed the following applets and apps to use KPopupMenu with a title and icon in the title and added the standard icons for "Preferences..." etc. were they were missing. I also changed KSystemTray::contextMenu() to include kapp->miniIcon() in the title, and not only kapp->caption(): Dock apps: klipper korn ksirc kteatime kmix Panel applets: clockapplet (erm, there is no small "clock" icon yet?) minipager kmixapplet Question to the authors: Do you have any objections against those changes? IMHO it looks more consistent. Thanks for your comments, -Malte -------------------------------------------------------- Now we just need to make klipper an *option* to get consistency... -anders >> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<