[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Bug#11443
From:       Jesse Barnes <jbarnes () spamtin ! engr ! sgi ! com>
Date:       2000-09-30 1:44:50
[Download RAW message or body]

I made a patch of the rewrite you sent me and tested it, so here it
is.  I'm happy to finally have a working file dialog :).  Thanks a lot.

Jesse

--- kurlcombobox.cpp.orig	Fri Sep 29 18:32:44 2000
+++ kurlcombobox.cpp	Fri Sep 29 18:42:04 2000
@@ -310,19 +310,14 @@
 void KURLComboBox::updateItem( const KURLComboItem *item,
                                int index, const QPixmap& pixmap )
 {
-    //TODO: a getText method for this
-    const QString &text = isEditable() ?
-                          ( item->url.isLocalFile() ? item->url.path(myMode) : \
                item->url.prettyURL(myMode) )
-                          : item->text;
-
-    // QComboBox::changeItem() doesn't honour the pixmap when
-    // using an editable combobox, so we just remove and insert
-    if ( isEditable() ) {
-        removeItem( index );
-        insertItem( pixmap, text, index );
-    }
-    else
-        changeItem( pixmap, text, index );
+  if ( isEditable() ) {
+    removeItem( index );
+    insertItem( pixmap, item->url.isLocalFile() ? item->url.path( myMode ) :
+                                              item->url.prettyURL( myMode ),
+               index );
+  }
+  else
+    changeItem( pixmap, item->text, index );
 }
 
 



 
> > Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]