[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    compilation patch for imageXVDesk.cpp
From:       "Christophe Prud'homme" <prudhomm () MIT ! EDU>
Date:       2000-09-30 1:14:00
[Download RAW message or body]

Hi
it seems that someone commented out a few things a bit too quickly in this 
file

the patch is attached.
Notice the sane use of parenthesis :)
I think that is good practice to use parenthesis ALL THE TIME even for one 
instruction. 

regards
C.
-- 
   Christophe Prud'homme                  |
   MIT, 77, Mass Ave, Rm 3-243            |    Do nothing unless you must,
   Cambridge MA 02139                     |    and when you must act
   Tel (Office) : (00 1) (617) 253 0229   |    -- hesitate.
   Fax (Office) : (00 1) (617) 258 8559   |
   http://augustine.mit.edu/~prudhomm     |
                          Following the hacker spirit

["imageXVDesk.cpp.diff" (text/x-c)]

Index: util/render/x11/imageXVDesk.cpp
===================================================================
RCS file: /home/kde/kdemultimedia/mpeglib/lib/util/render/x11/imageXVDesk.cpp,v
retrieving revision 1.6
diff -c -r1.6 imageXVDesk.cpp
*** util/render/x11/imageXVDesk.cpp	2000/09/29 15:38:59	1.6
--- util/render/x11/imageXVDesk.cpp	2000/09/30 01:09:43
***************
*** 178,189 ****
--- 178,195 ----
  			 &p_event_base, &p_error_base);
    if (ret != Success) {
      if (ret == XvBadExtension)
+       {
        //printf("XvBadExtension returned at XvQueryExtension.\n");
+       }
      else
        if (ret == XvBadAlloc)
+ 	{
  	//printf("XvBadAlloc returned at XvQueryExtension.\n");
+ 	}
        else
+ 	{
  	//printf("other error happened at XvQueryExtension.\n");
+ 	}
      return false;
    }
    /*
***************
*** 202,213 ****
--- 208,225 ----
    
    if (ret != Success) {
      if (ret == XvBadExtension)
+       {
        //printf("XvBadExtension returned at XvQueryExtension.\n");
+       }
      else
        if (ret == XvBadAlloc)
+ 	{
  	//printf("XvBadAlloc returned at XvQueryExtension.\n");
+ 	}
        else
+ 	{
  	//printf("other error happaned at XvQueryAdaptors.\n");
+ 	}
      return false;
    }
    /*

>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]