[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kio_http updates (was: https support in KDE)
From:       Alexander Feigl <Alexander.Feigl () gmx ! de>
Date:       1999-11-07 20:40:00
[Download RAW message or body]

At Son, 07 Nov 1999 Stephan Kulow wrote:
> Alexander Feigl wrote:
> > 
> > At Son, 07 Nov 1999 Stephan Kulow wrote:
> > > Alexander Feigl wrote:
> > > >
> > > > At Son, 07 Nov 1999 David Faure wrote:
> > > > > On Sun, Nov 07, 1999 at 05:03:10AM +0100, Alexander Feigl wrote:
> > > > > > At Son, 07 Nov 1999 Alex Zepeda wrote:
> > > > > > > > I am making experients with kio_http to make https work (again?). Are
> > > > > > > > there any chances I get a patch commited? (maybe after Krash). https
> > > > > > > > seems to work on my machine now after doing dozens of fixes but I
> > > > > > > > still have to check wheter communication is really encrypted.
> > > > > > >
> > > > > > >
> > > > > > > Sure, I'd like to see the patch(es), before they get committed, if they
> > > > > > > get committed.  I can't imagine dozens of fixes being needed, perhaps
> > > > > > > dozens of somewhat obscure features being added..  And yes, last time I
> > > > > > > tried it, the communication was really encrypted.
> > > > > > >
> > > > > >
> > > > > > I didn't count the fixes so "dozens" was only a fictive number. :)
> > > > > >
> > > > > > I mailed the patch to Faure before you wrote this mail. He said I should mail
> > > > > > it to ONE person - he didn't say who should get it.
> > > > > ... because I thought it was more trivial (you know, just patch and apply),
> > > > > eeventually with Makefile.am fixes. It turns out there are configure changes as
> > > > > well (I forwarded them to Stephan who's in charge, and more knowledgeable, for that).
> > > > >
> > > >
> > > > I think it would be a good idea to do that as a m4 macro . configure.in.in does
> > > > not get messy and we can move it to global admin when more apps need this
> > > > (perhaps kmail for S/MIME). I attached a .m4 macro which would work. It is a
> > > > copy/modify of the QT path equivalent.  It defines/undefines HAVE_SSL for
> > > > config.h and sets SSL_INCLUDES SSL_LDFLAGS and LIBSSL which could be used in
> > > > Makefile.am.
> > > >
> > > > If the OpenSSL check becomes a m4 macro, Stephan could check it. It works for me
> > > > and was a good lesson in m4/autoconf stuff (learning by doing :) )
> > > >
> > > Looks good - seems you had a good teacher :)
> > >
> > > Greetings, Stephan
> > 
> > Thanks :)  Can the changes be committed before the freeze? I patched together an
> > auto-configuring version running on my machine. It is just compiling and do
> > some testing this evening. I have set up a local SSL HTTP server - so I don't
> > need to be online the whole night :)
> > 
> Just put the code and the call into kdebase/kioslaves/configure.in.in
> I don't like all the configure switches, can you put only the prefix
> one? If someone has very weired locations, he can still use
> --with-extra-includes...
> 

Ok, I'll prepare a patch. Who feels responsible in reviewing and commiting
it? (don't have access to the repository)


Greetings

Alexander

[prev in list] [next in list] [prev in thread] [next in thread]