[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Random Background feature partly broken in KDE-1.1.2 (worked
From:       Duncan Haldane <f.d.m.haldane () mciworld ! com>
Date:       1999-09-04 19:53:11
[Download RAW message or body]


On 04-Sep-99 Dirk A. Mueller wrote:
> Duncan Haldane <f.d.m.haldane@mciworld.com> wrote:
> 

> I've read it now, and imho this way of configuring is far too difficult
> and everything else than intuitive.
> 
> imho this needs to be redesigned for KDE 2.0.
> 
> Is this manual translated into other languages?
> 
> if not, then I suggest the following patch: (kdebase/kcontrol/display)

Yes.  Good Patch. (which now opens up a file chooser dialog)
I tested and applied it to the cvs.
Now the functionality of this feature is restored.
I also updated the help docs.

The feature is not quite perfect, as whatever is selected as the wallpaper
in the main Background dialog screen overwrites the first item in the
"Desktops" box list when the Random Mode setup dialog is opened, but ....
I dont have the energy to hunt down and fix this little detail.
At least the feature is not 100% broken anymore...

duncan


 
> Index: backgnd.cpp
> ===================================================================
> RCS file: /home/kde/kdebase/kcontrol/display/backgnd.cpp,v
> retrieving revision 1.43.2.5
> diff -u -r1.43.2.5 backgnd.cpp
> -+- backgnd.cpp 1999/08/25 08:47:40 1.43.2.5
> +++ backgnd.cpp 1999/09/04 18:12:34
> @@ -1903,7 +1903,9 @@
> 
>  void KRandomDlg::slotAdd()
>  {
> -  addToPicList( i18n("No wallpaper") );
> +  QString name=KFileDialog::getOpenFileName(kapp->kde_wallpaperdir());
> +  if(!name.isEmpty())
> +    addToPicList(name);
>  }
> 

[prev in list] [next in list] [prev in thread] [next in thread]