[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: I'm back - test this fix please...
From:       iglio () fub ! it (Pietro Iglio)
Date:       1999-08-24 14:59:17
[Download RAW message or body]

At 10.30 24/08/99 -0400, you wrote:
>Greetings,
>
>On Tue, 24 Aug 1999, Waldo Bastian wrote:
>> The patch is ok and I would certainly apply it but I don't see how this
>> could have caused the "Malformed URL".
>> 
>> Cheers,
>> Waldo
>
>I know why.  We had a similar bug report in kfm.  The problem was that KURL
>never cleaned the path if you entered a local URL w/o the protocol i.e
>"file:/".  So in this case the double ("//") slashes before "kdisknav" was
not
>cleaned up.  I have already fixed this in KURL as it was a one liner, add
>cleanPath(), before storing URLs that begin with "/".  So the patch is not
>really necessary since the issue is resolved several days ago in CVS...
>
>Cheers,
>Dawit A.

OK. This means that I'll commit the patch AFTER 1.1.2 has been frozen.

-- Pietro


>> On Tue, 24 Aug 1999, Uwe Thiem wrote:
>> > On Tue, 24 Aug 1999, Pietro Iglio wrote:
>> > 
>> > I'm currently compiling the 19990819 snapshots. As soon as I'm
>> > through with it I'll give it a try.
>> > 
>> > Uwe
>> > 
>> > > ---------------------------- BUG REPORT --------------------------
>> > > Subject: Bug#1792: Disk-Navigator - Einstellungen
>> > > Date: 	Mon, 23 Aug 1999 23:39:21 +0200
>> > > From: 	Richard Brunner <richard.brunner@vol.at>
>> > > 
>> > > Package: kpanel
>> > > Version: KDE1_1-CVS (22/08/99)
>> > > 
>> > > If I click on "edit shared" the msgbox with "Malformed URL
>> > > /opt/kde/share/apps//kdisknav" appears.
>> > > 
>> > > I am using SuSE 6.2 with Kernel 2.2.11 and glibc 2.1
>> > > 
>> > > -------------------------------------------------------------------
>> > > 
>> > > Here is the (trivial) patch:
>> > > 
>> > > file: kdebase/kcontrol/kpanel/disknav.cpp
>> > > 
>> > > void KDiskNavConfig::edit_shared_clicked()
>> > > {
>> > >   KShellProcess proc;
>> > > -  proc << "kfmclient folder " + KApplication::kde_datadir() + "/" +
>> > > "/kdisknav";
>> > > +  proc << "kfmclient folder " + KApplication::kde_datadir() +
"/kdisknav";
>> > >   proc.start(KShellProcess::DontCare);
>> > > }
>> > > 
>> > > 
>> > > Since the 1.1.2 branch is frozen, I need at least two developers
that approve
>> > > this patch.
>> > > 
>> > > -- Pietro

[prev in list] [next in list] [prev in thread] [next in thread]