From kde-devel Fri Aug 20 08:33:15 1999 From: Peter Putzer Date: Fri, 20 Aug 1999 08:33:15 +0000 To: kde-devel Subject: Re: [PATCH] for kdehelp & bzip2'ed man-pages/info-files (fwd) X-MARC-Message: https://marc.info/?l=kde-devel&m=93514864111196 On Thu, 19 Aug 1999, Harri Porten wrote: > Peter Putzer wrote: > > > > Please have a look at the included patches, they are really small and > > missing bzip2-support is a bug IMNSHO. > > They look okay. I wonder if putting the for(int i=0; i<2; i++) around > _everything_ once would have been a cleaner solution that putting it > into the algorithm several times. Doesn't matter. We are not talking > about the Kernel here. I pondered that, but then several checks would have been made twice, so I think it actually is faster (if not as tidy) this way... What should have been done is #defining a symbol for "2"... but I didn't think of it at the time I did the patch, and was to lazy afterwards. > > Patch2 unfortunately includes a bit of cruft because of XEmacs > > re-indentation... > > I tried to fix the indentation as good as possible to adhere to Martin's > coding style. Due to the added level the lines became a bit wide though. Yeah, sorry, that's why I originally re-indented it... to see what I was doing! > I'll put the patch in assuming that you tested it well enough ;) I just > read trough every line carefully and tested it with one or two gzipped > man pages. I did, I use a patched kdehelp for the second week now, without any problems. One thing I noticed, though: while alle manpages can be accessed via entering the URL, the index shows only the basic manpages (i.e. /usr/man), nothing from /usr/X11R6/man (didn't check for /opt or other dirs)! Unfortunately I haven't yet had time to investigate this... and I hate the code, to be honest. I don't see why all these gotos are neccessary *yuck* bye, Peter PS: this is not meant as criticizing Martin's work, but I think the code simply shows its age, AFAIK kdehelp basically was done 2 years ago, and hasn't changed much.