[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Bug in kwm/gradientFill.C
From:       Stephan Kulow <coolo () caldera ! de>
Date:       1999-08-20 7:50:22
[Download RAW message or body]

Harri Porten wrote:
> 
> Mosfet wrote:
> >
> > We shouldn't have to include edian.h but instead be using
> > QImage::systemBitOrder and QImage::systemByteOrder. I brought this up before
> > and that is what I thought was being done.
> 
> I remember you proposing that but when I looked at the doc a just saw
> QImage::bitOrder and thought it wouldn't work.
> 
> On a second glance I see that you (and Uwe with qSysInfo()) are right.
> 
> > I need to recheck out the KDE2 CVS so if someone wants to make the needed
> > changes go for it.
> 
> I don't like putting runtime checks in speed critical code like
> gradients. ifdefs should be prefered but since this is the stable branch

It doesn't check this every time, but you're right, it would slow it
down
a bit.

Greetings, Stephan

-- 
Better give your hours some more life than
your life some more hours. - anonymous

[prev in list] [next in list] [prev in thread] [next in thread]