[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch for debase/kioslave/ftp?
From:       Waldo Bastian <bastian () suse ! de>
Date:       1999-08-06 8:51:51
[Download RAW message or body]

On Fri, 06 Aug 1999, Magnus Benngard wrote:
> Without patch:
> 
> [dns]/usr/local/src/kde/kdebase/kioslave/ftp# make
> g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/local/kde/include \
> -I/usr/local/qt/include  -I/usr/X11R6/include    -O2 -c main.cc In file included \
> from main.h:11, from main.cc:14:
> ftp.h:125: invalid type `const QString' for default argument to `QString &'
> make: *** [main.o] Error 1
> [dns]/usr/local/src/kde/kdebase/kioslave/ftp
> 
> With patch:
> 
> [dns]/usr/local/src/kde/kdebase/kioslave/ftp# make
> g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/local/kde/include \
> -I/usr/local/qt/include  -I/usr/X11R6/include    -O2 -c main.cc g++ -DHAVE_CONFIG_H \
> -I. -I. -I../.. -I/usr/local/kde/include -I/usr/local/qt/include  \
>                 -I/usr/X11R6/include    -O2 -c ftp.cc
> /bin/sh ../../libtool --silent --mode=link g++  -O2 -L/usr/local/kde/lib \
> -L/usr/local/qt/lib  -L/usr/X11R6/lib -rpath /usr/local/kde/lib -rpath \
> /usr/local/qt/lib -rpath /usr/X11R6/lib -o kio_ftp  main.o ftp.o -lkio \
> [dns]/usr/local/src/kde/kdebase/kioslave/ftp

The patch is wrong. (The orignal code as well) It casts a const QString
to QString & which in this case is simply incorrect. The correct
solution is to fix the argument-type this function takes and adapt the
code for this.

Cheers,
Waldo


[prev in list] [next in list] [prev in thread] [next in thread]