[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    PATCH (was: KFM(client) Bug in KDE 1.1.1)
From:       Waldo Bastian <bastian () suse ! de>
Date:       1999-08-04 16:34:17
[Download RAW message or body]

On Wed, 04 Aug 1999, Waldo Bastian wrote:
> On Wed, 04 Aug 1999, Dawit Alemayehu wrote:
> > On Tue, 03 Aug 1999, Markus Goetz wrote:
> > > Hi all,
> > > 
> > > i have the following problem :
> > > 
> > > A program i wrote calls kfmclient with 'openURL' and an URL that is generated
> > > dynamically and looks (e.g.) like
> > > 'http://yp.icecast.org/index.html?search=german%20music'.
> > 
> > Ummm.  This is a query ; so shouldn't the URL actually read :
> > 'http://yp.icecast.org/index.html?search=german+music;
> 
> Both are valid.
>   
> > > I call kfmclient with system("kfmcl....") and everything seems to work fine.
> > > The typical small windows with the 'Trying to open http..' pops up (with the
> > > right URL) and after a few seconds a new kfm window comes out, again with the
> > > URL, but not decoded, %20 is again a ' ' !
> > 
> > Well somewhere along the line a KURL::decodeURL( ... ) is called before the
> > location box is updated.  Note that although this is misleading/confusing, this
> > does not affect kfm internally as the encoded URL is used, atleast as far as I
> > can remember.
> 
> The whole concept of "decodeURL" is broken. You can't decode an URL
> without breaking it up in the various parts. Take e.g.
> <http://www.kde.org/path/some%3Ffile?search=german+music>

The following patch solves this. I think it is correct to apply it.
Could someone have a look at it so that it can be included
in 1.1.2?

Cheers,
Waldo
["kdebase.kfm.04-08-99.diff" (text/x-c++)]

Index: kfmgui.cpp
===================================================================
RCS file: /home/kde/kdebase/kfm/Attic/kfmgui.cpp,v
retrieving revision 1.167.2.14
diff -u -r1.167.2.14 kfmgui.cpp
--- kfmgui.cpp	1999/07/29 13:43:28	1.167.2.14
+++ kfmgui.cpp	1999/08/04 16:28:30
@@ -796,7 +796,6 @@
     KURL u(_url);
     u.setPassword(""); // hide password
     QString url(u.url().copy());
-    KURL::decodeURL(url);
     toolbarURL->setLinedText( TOOLBAR_URL_ID, url.data() );
     //  update tree view Sep 5 rjakob
     if (u.isLocalFile())


[prev in list] [next in list] [prev in thread] [next in thread]