[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Seg Fault in KPanel /KDE_1_1_Branch (fwd)
From:       Harri Porten <porten () tu-harburg ! de>
Date:       1999-07-05 15:02:40
[Download RAW message or body]

Stephan Kulow wrote:
> 
> > @@ -351,6 +351,8 @@
> >    int i = 0;
> >    int nw = kwmmapp->windows.count();
> >    p->clear();
> > +  if (callbacklist)
> > +    delete [] callbacklist;
> >    callbacklist = new Window[nw];
> >    for (w = kwmmapp->windows.first(); w; w = kwmmapp->windows.next())
> >      callbacklist[i++]=*w;
> 
> Well, delete [] 0 is very much legal. I don't know why people keep
> on adding "if (ptr) delete ptr;" :(

I'm still discussing with Pietro how the final fix will look like. Since
he's the kpanel maintainer I'll better accept his patches so close to a
release ;).

kwm and kpanel are still constantly leaking memory on almost every
action but (apart from a fix for a 12 bytes/min leak coming from the
clock tooltip) I don't want to burn my fingers anymore.

Harri.

[prev in list] [next in list] [prev in thread] [next in thread]