[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: jpeg and egcs optimization problems? (1.1 branch)
From:       Harri Porten <porten () tu-harburg ! de>
Date:       1999-06-29 8:50:27
[Download RAW message or body]

Alex Zepeda wrote:
> 
> Has anyone seen bug report #953?  Or would someone please take a look?
> The patch attached to it appears quite sane, and while according to the
> report, egcs would be at fault, the work around seems acceptable.
> Comments?  Objections to me committing this?

I've looked at it before but was too chicken to fix it since I wasn't
sure what the original author actually intended to do. I agree with the
submitter of the patch that 

*ui_row++ = qRgb(*uc_row++,*uc_row++,*uc_row++);

is a dangerous operation. Is the behaviour really defined ? The patch
looks okay and the guy sending it seems to have verified it's success.

I'd say that you can commit it to both branches.

Harri.

[prev in list] [next in list] [prev in thread] [next in thread]