[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: got it! ;)
From:       David Faure <david.faure () insa-lyon ! fr>
Date:       1999-06-15 10:54:34
[Download RAW message or body]

On Tue, Jun 15, 1999 at 12:38:18PM +0200, Reginald Stadlbauer wrote:
> On Tue, 15 Jun 1999, David Faure wrote:
> >We should definitely have a naming convention for macros.
> >Some standard I've seen often is all caps, but that's no obligation.
> >
> >A fast grep tells me that we have currently :
> >kapp
> >klocale
> >locate
> >Icon
> >ICON
> >RESTORE
> >
> >and all kom/op macros which are all caps.
> >(SIGNAL_IMPL, EVENT_MAPPER, MAPPING, ...)
> >
> >So : what about KAPP, KLOCALE, LOCATE and getting rid of "Icon" ?
> 
> This would mean you have to write 
>   KAPP->something()
> instead of
>   kapp->something() 
> then?
> 
> Looks ugly IMHO.
It's a matter of taste (and habit), but I think it would make
it easier for the new developers to understand that it's a macro,
and not a private member or whatever it could be...

kapp is easy to understand, but when one sees locate() in a c++ file,
how can he guess that it's a macro, and that it's defined in kstddirs.h ?

-- 
David FAURE
david.faure@insa-lyon.fr, faure@kde.org
http://www.insa-lyon.fr/People/AEDI/dfaure/index.html 
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]