[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Joke in kconfigbase.h
From:       Stephan Kulow <coolo () alpha ! tat ! physik ! uni-tuebingen ! de>
Date:       1999-05-22 9:45:34
[Download RAW message or body]

Kurt Granroth wrote:
> 
> Stephan Kulow wrote:
> > Kurt Granroth wrote:
> > > Stephan Kulow wrote:
> > > > This script of Kurt is a real pain. We have tons of code in kdecore
> > > > that is simply broken, because some script replaced const char with
> > > > QString.
> > >
> > > Me?  Or a different Kurt?  What script are you talking about?
> >
> > About this one? granroth is you, not? I suffered from this commit
> > weeks later.
> >
> > Greetings, Stephan
> >
> > revision 1.7.4.1
> > date: 1999/02/14 02:05:41;  author: granroth;  state: Exp;  lines: +10
> > -4
> > Converted a lot of 'const char*' to 'QString'.  This compiles... but
> > it's entirely possible that nothing will run linked to it :-P
> 
> Hey.. I forgot about that.  *blush*
> 
> How is the code broken, BTW?  I thought it mostly worked way back then (3
> months ago)...

You replaced much too many const char*, so creating lots of implicit
ascii casts. For example there were code like
KClass(const QString& name) : QObject(name)
where the QObject call casts down to const char*.

And there are a lot of "const QString" as return values, but I'm not
sure
if that was your script too.

Greetings, Stephan

-- 
Und sie nannten ihn, wie er selbst unterschrieb -
Den Trojanischen Pferdedieb

[prev in list] [next in list] [prev in thread] [next in thread]