[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kpanel
From:       Stephan Kulow <coolo () kde ! org>
Date:       1998-12-28 17:29:14
[Download RAW message or body]

Hans Petter Bieker wrote:
> 
> Where did all the msgs ago when the list was down? <g>
> 
> ---------- Forwarded message ----------
> Date: Sat, 26 Dec 1998 14:09:35 +0100 (CET)
> From: Hans Petter Bieker <zerium@webindex.no>
> To: kde-devel@kde.org
> Subject: kpanel
> 
> The string:
> "Open this folder (+Shift: Launch a terminal here)"
> ...in kpanel isn't i18n()ed.
> 
> (Hm... didn't I fix this long time ago??)
> 
> Here is the patch:
> --- pfilemenu.C.orig    Sat Dec 26 14:00:02 1998
> +++ pfilemenu.C Sat Dec 26 14:00:45 1998
> @@ -72,7 +72,7 @@
>  #define KDISKNAV_SHARED_DIR       KApplication::kde_datadir() + "/kdisknav"
>  #define KDISKNAV_PERSONAL_DIR        "/.kde/share/apps/kdisknav"
> 
> -#define OPEN_FOLDER_TIP   "Open this folder (+Shift: Launch a terminal here)"
> +#define OPEN_FOLDER_TIP   i18n("Open this folder (+Shift: Launch a terminal here)")
> 
>  #define GET_DEFAULT_FILE_ICON(fi)  \
>     ((fi).isExecutable() ? DEFAULT_EXECUTABLE_ICON : DEFAULT_FILE_ICON)
> @@ -480,7 +480,7 @@
>      this->add( new PMenuItem(prog_com, klocale->translate("Open Folder"),
>                             0, "folder_open.xpm", 0,
>                             this, SLOT(openFolder()), 0, false, 0,
> -                           klocale->translate(OPEN_FOLDER_TIP)) );
> +                           OPEN_FOLDER_TIP) );
>      this->add( new PMenuItem(separator) );
>    }
> 
> (why use OPEN_FOLDER_TIP in the first place btw?:
> --- pfilemenu.C.orig    Sat Dec 26 14:00:02 1998
> +++ pfilemenu.C Sat Dec 26 14:07:52 1998
> @@ -72,8 +72,6 @@
>  #define KDISKNAV_SHARED_DIR       KApplication::kde_datadir() + "/kdisknav"
>  #define KDISKNAV_PERSONAL_DIR        "/.kde/share/apps/kdisknav"
> 
> -#define OPEN_FOLDER_TIP   "Open this folder (+Shift: Launch a terminal here)"
> -
>  #define GET_DEFAULT_FILE_ICON(fi)  \
>     ((fi).isExecutable() ? DEFAULT_EXECUTABLE_ICON : DEFAULT_FILE_ICON)
> 
> @@ -480,7 +478,7 @@
>      this->add( new PMenuItem(prog_com, klocale->translate("Open Folder"),
>                             0, "folder_open.xpm", 0,
>                             this, SLOT(openFolder()), 0, false, 0,
> -                           klocale->translate(OPEN_FOLDER_TIP)) );
> +                           i18n("Open this folder (+Shift: Launch a terminal here)")));
>      this->add( new PMenuItem(separator) );
>    }
> 
Using i18n in a #define is not good, since xgettext can't
handle this ;(
So I would vote for the second patch.

Greetings, Stephan

-- 
A big plus when your parents split up, is, that you don't
have to imagine them doing it again. * Mr. Rhodes

[prev in list] [next in list] [prev in thread] [next in thread]