[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    KFM problem: Stop button
From:       Johannes Sixt <Johannes.Sixt () telecom ! at>
Date:       1997-12-26 19:15:28
[Download RAW message or body]

When accessing an ftp-URL, such as ftp://localhost, and pressing the Stop button
while kfm is still downloading, it exits with "Virtual memory exceeded in
`new'". I've tracked down the problem and found that KHTMLWidget::end() is
called without a KHTMLWidget::begin().

The following patch cures the symptom, but I'm afraid that the "disease" is
someplace else:

--- kdelibs/khtmlw/htmltoken.cpp.orig   Mon Dec  1 10:34:37 1997
+++ kdelibs/khtmlw/htmltoken.cpp        Fri Dec 26 19:03:12 1997
@@ -632,6 +632,10 @@
 
 void HTMLTokenizer::end()
 {
+    // J6t: protect against end() called without begin()
+    if (buffer == 0)
+       return;
+
     if ( dest > buffer )
     {
        *dest = 0;

I'm using snapshot 971219.

-- Hannes

[prev in list] [next in list] [prev in thread] [next in thread]