[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Incubation Request: Kiview
From:       Sune Vuorela <nospam () vuorela ! dk>
Date:       2024-04-29 7:21:03
Message-ID: v0nhov$dcq$1 () ciao ! gmane ! io
[Download RAW message or body]

On 2024-04-28, Méven <meven29@gmail.com> wrote:
> The immediate goal with this application is to fill this request feature
> for dolphin :
> https://bugs.kde.org/show_bug.cgi?id=272539
> And we can imagine reusing it in many other places potentially.

I just opened 'DocumentViewer' class and spent 5 minutes and got a bit
scared.

"instant" preview?

Launching a background libreoffice?
Doing weird command line parsing of libreoffice? and bash pipe grep ?
Then throwing a generated pdf at qtwebengine and hoping the best?

There is a lot of std::tsring to qstring and back again conversions

There are plenty of std::string deepcopies.

Who deletes ConversionThread ?

If this class is in any way representative of the code quality of the
app, I really think we should reconsider.

If this class is not representative, then it definitely should be
architecturally re-done.

/Sune

[prev in list] [next in list] [prev in thread] [next in thread]