[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Policy on merge-requests for developers. ( Specifically snapcraft transition )
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2023-10-18 19:56:44
Message-ID: 3024725.EcKkvGaknC () xps15
[Download RAW message or body]

El dimecres, 18 d'octubre de 2023, a les 19:17:05 (CEST), Scarlett Moore va 
escriure:
> Hello!
> As you have probably seen the noise, I have been busy transitioning
> snapcraft files to their respective repo. After I had already made it
> 3/4 of the way through I was asked to do MRs for this transition,
> which is no problem at all, I have already done so. However, I have
> only received one approval. I only touch snap related files and I now
> know to add license headers to said files.. If the tests pass, am I
> allowed to merge these myself? Or do I need to wait? This will make my
> releases for snaps difficult and prolonged.I guess not something I
> considered when proposing this.

I find that auto approving one own's MRs after a few days is ok if you're an 
expert in the field and noone has disagreed. 

Doing a MR makes sure you don't inadvertently break the build, we all think 
we're infallible but still mess it up from time to time.

Cheers,
  Albert

> Thanks for any insight,
> Scarlett




[prev in list] [next in list] [prev in thread] [next in thread]