From kde-devel Thu Mar 09 16:55:50 2023 From: Volker Krause Date: Thu, 09 Mar 2023 16:55:50 +0000 To: kde-devel Subject: Re: Usage of KF5/KF6 in targets and CMake config files outside of Frameworks Message-Id: <1955674.usQuhbGJ8B () vkpc5> X-MARC-Message: https://marc.info/?l=kde-devel&m=167838097805557 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart3419773.QJadu78ljV" --nextPart3419773.QJadu78ljV Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday, 9 March 2023 16:58:40 CET Heiko Becker wrote: > while looking at a MR for libkcddb (part of Gear) I wondered if the > transition > from Qt5/KF5 to Qt6/KF6 could be used to get rid of the KF5/6 prefix in > target > names and CMake config files for libraries that aren't acutally part of > Frameworks. > > It always seemed a bit illogical and possibly confusing to me to have e.g. > KF5Cddb as CMake config file and KF5::Cddb as target name, because it's > masquerading to be part of something (Frameworks), which isn't actually > true. > Especially since we market Frameworks as a common group of libraries, with > common rules and policies, which may only be followed in part (or maybe not > at all) by other projects. > > Changing that obviously involves some (temporary) compatibility concerns, > but that doesn't play any role with the move to Qt6/KF6. So I suggest to > use the chance and get rid of said prefix with the upcoming porting. > > One example where this was done already some time ago is libkgapi: > https://invent.kde.org/pim/libkgapi/-/commit/8d15e66f1ed87a52377111735e24888 > b7f924a49 ... and much more recently in a number of other PIM modules as well. My impression so far was that it's already largely consensus that using the KF prefix outside of Frameworks was a mistake we made in the early 5 days, and that should be corrected when the opportunity arises. There is one possible exception I can see for this, libraries with an imminent move to Frameworks. We have used the fact those were already using the KF prefix in several cases (e.g. KContact, KCalendarCore, KDAV) for a seamless switch from Gear to Frameworks. Many of the remaining users don't fall into that category though. Regards, Volker --nextPart3419773.QJadu78ljV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQAnu3FVHA48KjZ07R/lszWTRLSRwUCZAoPlgAKCRB/lszWTRLS R+kGAJ4stCbB9pmqaoLtF5bPpAJw60VdcwCdEEtnKyM6yP6ZXtTeK8MnFLHQc2s= =qLDM -----END PGP SIGNATURE----- --nextPart3419773.QJadu78ljV--