[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Copying po/docbook files to repositories nightly
From:       Alvin Wong <alvin () alvinhc ! com>
Date:       2022-10-08 9:19:41
Message-ID: cfaba25e-3bcd-c0a5-4adb-f7154585541b () alvinhc ! com
[Download RAW message or body]

Hi,

On 8/10/2022 5:07, Albert Astals Cid wrote:
> El dimecres, 5 d'octubre de 2022, a les 18:59:08 (CEST), Alvin Wong va
> escriure:
> > Hi,
> > 
> > I notice this has been applied to docs-krita-org
> > <https://invent.kde.org/documentation/docs-krita-org/-/tree/krita/5.1>.
> > However, being a Sphinx doc project it already has a `StaticMessages.sh`
> > script to copy the PO files into the `locale/` directory and "unflatten"
> > the directory layout to what the Sphinx build expects (the files in the
> > l10n SVN tree have the directory layout flattened by mangling the
> > filenames). Now the files are also being copied to the `po/` directory, but
> > in the flattened layout, which in practice are unused duplicated copies.
> > Should we opt-out of this copying step to avoid the duplicated files, or is
> > there a better way to handle this?
> We will make it so that for StaticMessages.sh the po files are not copied back.

Thanks.

> > By the way, it seems the existing `StaticMessages.sh` copy step is slightly
> > out of sync with the new copy step (the git commits don't have identical
> > diff contents). Is this something to be concerned about?
> Can you point me to such discrepancy?

For example, compare the last `StaticMessages.sh` update "made messages 
(after extraction)" 
<https://invent.kde.org/documentation/docs-krita-org/-/commit/8fefc58a53abf726f2ff4860374da440544a88ea> \
 and the last PO copy change "Sync po/docbooks with svn" 
<https://invent.kde.org/documentation/docs-krita-org/-/commit/5d467f31b22cbdde6940153720f457d1bc96df6d>, \
 the list of changed files are different. The commit "Sync po/docbooks 
with svn" changed 
`po/ca/docs_krita_org_contributors_manual___krita_manual_conventions.po` 
with the POT creation date updated to "2022-10-08", while "made messages 
(after extraction)" did not change 
`locale/ca/LC_MESSAGES/contributors_manual/krita_manual_conventions.po` 
-- at this commit, this file still has a POT creation date of 
"2022-10-04" 
<https://invent.kde.org/documentation/docs-krita-org/-/blob/5d467f31b22cbdde6940153720 \
f457d1bc96df6d/locale/ca/LC_MESSAGES/contributors_manual/krita_manual_conventions.po>.


Best Regards,
Alvin


> Cheers,
> Albert
> 
> > Best Regards,
> > Alvin
> > 
> > > El divendres, 2 de setembre de 2022, a les 23:24:21 (CEST), Albert Astals
> > > Cid>
> > > va escriure:
> > > > /As you may know, translations for apps don't live in the same place as
> > > > the />/code for the apps themselves. />//>/This greatly benefits
> > > > translators but is not awesome for the release />/management side of
> > > > things since it means that for each release we need to />/not forget to
> > > > copy the appropriate files to the appropriate place, makes />/tagging
> > > > somewhat harder, etc. />//>/For a while now we have been running an
> > > > "experimental" copy-po-qm-docbook- />/back-to-repository in a number of
> > > > "select" repositories and it seems to have />/worked quite well, you can
> > > > seem one example in
> > > > />/https://invent.kde.org/plasma-mobile/alligator/-/commits/master/po
> > > > />//>/The idea is to enable this for all repositories. />
> > > This has now been enabled for master branch and according to scripty logs
> > > all seems to have worked.
> > > 
> > > Please inspect your repositories and make sure the po files are there
> > > where
> > > they should and nothing broke.
> > > 
> > > Also please make sure you adapt your releasing scripts if you release from
> > > master.
> > > 
> > > Cheers,
> > > 
> > > Albert
> > > > //>/This is a heads up, as a developer there's nothing you need to do, at
> > > > most />/remove the po/ folder from .gitignore if for some reason it is
> > > > there. />//>/If you're a packager you will need to make sure your
> > > > scripts don't try to />/copy po/qm/docbook files anymore when doing a
> > > > release once this is />/activated. />//>/My plan would be to enable this
> > > > scripts over Akademy so we have the high />/bandwidth there to fix
> > > > things if needed. />//>/Opinions? Comments? />//>/Cheers, />/Albert/
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]