[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: How do you deal with incomplete commits?
From:       Thiago Macieira <thiago () kde ! org>
Date:       2020-11-01 17:52:27
Message-ID: 2451021.a0POV4Z2ol () tjmaciei-mobl1
[Download RAW message or body]

On Saturday, 31 October 2020 08:25:40 PST Thomas Friedrichsmeier wrote:
> thanks for your answer (also to Nate). But to clarify, my question is
> really: How do I _force_ myself to clean up in time?

If you're pushing to a code review system of any kind, it doesn't matter. 
First, you should always review what you've sent for review anyway and you can 
notice you pushed something incomplete. At that point don't create the review 
request or write that it isn't yet ready for review.

Second, your reviewers should notice it's incomplete and won't approve.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel DPG Cloud Engineering



[prev in list] [next in list] [prev in thread] [next in thread]