[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful
From:       "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date:       2019-10-25 18:43:55
Message-ID: 3178566.8gO3Xo1Qbv () klux
[Download RAW message or body]

Am Freitag, 25. Oktober 2019, 10:00:47 CEST schrieb David Faure:
> On vendredi 25 octobre 2019 08:39:24 CEST Volker Krause wrote:
> > In case this ends up being activated in production builds, this would
> > however require our ABI isn't changing by deactivating deprecated bits.
> > Enum values and vtable layouts look particularly in danger for this. I'm
> > not sure this was considered by deprecations predating the new
> > possibilities.
> 
> I think Friedrich took care of that when porting everything to the new
> macros. ABI-changing things are marked with *_BUILD_DEPRECATED_SINCE which
> is controlled by EXCLUDE_DEPRECATED_BEFORE_AND_AT which I'm not setting.

Correct.

> But yeah, maybe something slipped by. Once my KF5 build with
> KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00 is done
> [which requires porting 13 modules, apparently), I'll see if the rest of my
> Plasma session and KDE Applications (which I'm not recompiling) suffer from
> BIC changes :-)

Have to report that even after all the reviews of the respective patches for 
all the KF modules I had done, when doing a last personal review myself before 
finally pushing, I still found a few glitches where accidentally 
*_ENABLE_DEPRECATED_SINCE was used with virtuals or enums, which had slipped 
both eyes and my testing.
So while I hope we catched them all now, it will be good to have many people 
test-drive this a lot.

In a perfect world we would have resources to setup KDE CI to do lots of 
respective testing over the KF modules with different flags... where is the 
list for Santa C. ...

So for now curious for your results, David :) And glad to see this being 
adopted.

Cheers
Friedrich


[prev in list] [next in list] [prev in thread] [next in thread]