[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: RFC: Running clang-format across all Plasma (and more?) repos
From:       alcinos <french.ebook.lover () gmail ! com>
Date:       2019-07-11 15:31:20
Message-ID: CAHJBWf=UqzhfX72CiY69Hw7JuJdK0aq2UBOn4LjXXJO-g43ehA () mail ! gmail ! com
[Download RAW message or body]

Hi,

Just to mention that we have a .clang-format in Kdenlive as well (
https://invent.kde.org/kde/kdenlive/blob/master/.clang-format)
I designed it so that it would be consistent but match rather closely the
dominant style in the code-base at the time I wrote it.

Unfortunately, we don't currently have a strict enforcement of it through a
git hook, but this is definitely something worth looking into. LMK how it
goes if you actually enforce it. (Ideally, the Merge Requests in the gitlab
should also check for the style)

Cheers

Le jeu. 11 juil. 2019 =C3=A0 16:21, David Edmundson <david@davidedmundson.c=
o.uk>
a =C3=A9crit :

> One topic discussed at the recent Plasma sprint was that we should run
> a code formatting tool (clang-format) over all our repos to ease all
> future review comments about whitespace.
>
> All new contributions simply have to run the same tool and we get
> consistent code without having to comment on every minor thing in a
> review individually.
>
> I've written up a wall of text outlining steps, challenges etc.
> https://phabricator.kde.org/T11214
>
> Does anyone have any thoughts / objections?
>
> David
>

[Attachment #3 (text/html)]

<div dir="ltr">Hi,<div><br></div><div>Just to mention that we have a .clang-format in \
Kdenlive as well (<a \
href="https://invent.kde.org/kde/kdenlive/blob/master/.clang-format">https://invent.kde.org/kde/kdenlive/blob/master/.clang-format</a>)</div><div>I \
designed it so that it would be consistent but match rather closely the dominant \
style in the code-base at the time I wrote \
it.</div><div><br></div><div>Unfortunately, we don&#39;t currently have a strict \
enforcement of it through a git hook, but this is definitely something worth looking \
into. LMK how it goes if you actually enforce it. (Ideally, the Merge Requests in the \
gitlab should also check for the \
style)</div><div><br></div><div>Cheers</div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">Le  jeu. 11 juil. 2019 Ã   16:21, David Edmundson &lt;<a \
href="mailto:david@davidedmundson.co.uk">david@davidedmundson.co.uk</a>&gt; a écrit  \
:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">One topic discussed at \
the recent Plasma sprint was that we should run<br> a code formatting tool \
(clang-format) over all our repos to ease all<br> future review comments about \
whitespace.<br> <br>
All new contributions simply have to run the same tool and we get<br>
consistent code without having to comment on every minor thing in a<br>
review individually.<br>
<br>
I&#39;ve written up a wall of text outlining steps, challenges etc.<br>
<a href="https://phabricator.kde.org/T11214" rel="noreferrer" \
target="_blank">https://phabricator.kde.org/T11214</a><br> <br>
Does anyone have any thoughts / objections?<br>
<br>
David<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]