[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Gitlab Evaluation & Migration
From:       Eike Hein <hein () kde ! org>
Date:       2019-03-13 8:21:25
Message-ID: f3724e29-25d2-cf21-22c9-5f51b83f1756 () kde ! org
[Download RAW message or body]


Same. One thing I like very much about GitLab is that it puts the onus 
of merging post-review on the *reviewer*.

In this thread there have been some qualms on "is GitLab maybe harder on 
newbie devs", but this doesn't take into account the extremely awkward 
dance we currently do where we ask people if they have dev access or not 
and if they need help landing. In GitLab, once your MR is up there, and 
gets accepted, you're done - much smoother, no feeling of "you're not 
part of the team yet", etc. The reviewer just clicks "Merge" and it's in 
(no more fiddling with arc patch/land for the reviewer, either).

If Rebase is really convenient for reviewers (the button), that's more 
likely to stay that nice, because people don't get asked "can you rebase 
this for me", either. It builds on the strength.


Cheers,
Eike


On 3/12/19 7:05 PM, Andrius Štikonas wrote:
> Note that you can still do rebase merge manually. Gitlab can show the 
> list of commands
> that you need to run. In that list just replace git merge with rebase.
> 
> But I also prefer to just have a button.
> 
> Regards,
> Andrius
> 
> On 2019-03-12 04:46, Eike Hein wrote:
>> On 3/12/19 7:46 AM, Albert Astals Cid wrote:
>>> I asked for this too, i thought it had been enabled at some point, 
>>> but i guess not.
>>>
>>> So +1
>>
>> Seems it's currently being done on-demand, per-repo.
>>
>> The ticket I linked has a Rails snippet for doing it for all projects,
>> which sysadmin may find useful.
>>
>>
>>
>>> Cheers,
>>>    Albert
>>
>> Cheers,
>> Eike
[prev in list] [next in list] [prev in thread] [next in thread]