[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 129349: [baloo] add (and use) FileIndexerConfig::shouldFileBeIndexed(const QStrin
From: Christian Ehrlicher <ch.ehrlicher () gmx ! de>
Date: 2017-08-30 18:08:16
Message-ID: 20170830180816.1801.16777 () mimi ! kde ! org
[Download RAW message or body]
--===============8027707297312679331==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 29, 2017, 9:03 nachm., Kai Uwe Broulik wrote:
> > src/file/fileindexerconfig.cpp, line 173
> > <https://git.reviewboard.kde.org/r/129349/diff/3-4/?file=487422#file487422line173>
> >
> > You sure this doesn't crash? I've seen crashes when you directly chain a Ref to \
> > another method.
>
> Stefan Brüns wrote:
> Where do you see a chained ref?
I don't see a problem here. QString::midRef() returns a reference to path. \
QStringRef::mid() works on this reference and once again returns refernces to path. \
Since path is still alive then, all is fine. If this should somehow crash it's a but \
in Qt...
- Christian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129349/#review103663
-----------------------------------------------------------
On Aug. 24, 2017, 5:48 vorm., Christian Ehrlicher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129349/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2017, 5:48 vorm.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Use the new QStringRef class to avoid creation of temporary QString objects.
> Since every filename is sent through FileIndexerConfig::shouldFileBeIndexed(), I \
> think this is a good optimization although now there are two functions for \
> FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one with \
> QString and one with QStringRef ...
>
> Diffs
> -----
>
> src/engine/queryparser.cpp 9c3a4b60
> src/file/fileindexerconfig.h e2466bdd
> src/file/fileindexerconfig.cpp 0e4f4c45
> src/file/modifiedfileindexer.cpp d1f5011b
> src/file/newfileindexer.cpp 7e196229
> src/file/regexpcache.h 60d370de
> src/file/regexpcache.cpp 61f07d61
> src/file/xattrindexer.cpp 3daecef6
> src/kioslaves/timeline/timelinetools.cpp 26e44ee8
>
> Diff: https://git.reviewboard.kde.org/r/129349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christian Ehrlicher
>
>
--===============8027707297312679331==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129349/">https://git.reviewboard.kde.org/r/129349/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 29th, 2017, 9:03 nachm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129349/diff/3-4/?file=487422#file487422line173" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/fileindexerconfig.cpp</a> <span style="font-weight: normal;">
(Diff revisions 3 - 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">173</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QVector</span><span class="o"><</span><span \
class="n">QStringRef</span><span class="o">></span> <span \
class="n">pathComponents</span> <span class="o">=</span> <span \
class="n">path</span><span class="p">.</span><span class="n">mid</span><span \
class="p">(</span><span class="n">folder</span><span class="p">.</span><span \
class="n">count</span><span class="p">()).</span><span class="n">split<span \
class="hl">Ref</span></span><span class="p">(</span><span \
class="n">QLatin1Char</span><span class="p">(</span><span \
class="sc">'/'</span><span class="p">),</span> <span \
class="n">QString</span><span class="o">::</span><span \
class="n">SkipEmptyParts</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">173</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QVector</span><span class="o"><</span><span \
class="n">QStringRef</span><span class="o">></span> <span \
class="n">pathComponents</span> <span class="o">=</span> <span \
class="n">path</span><span class="p">.</span><span class="n">mid<span \
class="hl">Ref</span></span><span class="p">(</span><span \
class="n">folder</span><span class="p">.</span><span class="n">count</span><span \
class="p">()).</span><span class="n">split</span><span class="p">(</span><span \
class="n">QLatin1Char</span><span class="p">(</span><span \
class="sc">'/'</span><span class="p">),</span> <span \
class="n">QString</span><span class="o">::</span><span \
class="n">SkipEmptyParts</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
sure this doesn't crash? I've seen crashes when you directly chain a Ref to another \
method.</p></pre> </blockquote>
<p>On August 30th, 2017, 3:51 nachm. UTC, <b>Stefan Brüns</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Where \
do you see a chained ref?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I don't see a problem here. QString::midRef() returns a reference to path. \
QStringRef::mid() works on this reference and once again returns refernces to path. \
Since path is still alive then, all is fine. If this should somehow crash it's a but \
in Qt...</p></pre> <br />
<p>- Christian</p>
<br />
<p>On August 24th, 2017, 5:48 vorm. UTC, Christian Ehrlicher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Christian Ehrlicher.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2017, 5:48 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use the new QStringRef class to avoid creation of \
temporary QString objects. Since every filename is sent through \
FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization \
although now there are two functions for FileIndexerConfig::shouldFileBeIndexed() and \
RegExpCache::exactMatch() - one with QString and one with QStringRef ...</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/queryparser.cpp <span style="color: grey">(9c3a4b60)</span></li>
<li>src/file/fileindexerconfig.h <span style="color: grey">(e2466bdd)</span></li>
<li>src/file/fileindexerconfig.cpp <span style="color: grey">(0e4f4c45)</span></li>
<li>src/file/modifiedfileindexer.cpp <span style="color: \
grey">(d1f5011b)</span></li>
<li>src/file/newfileindexer.cpp <span style="color: grey">(7e196229)</span></li>
<li>src/file/regexpcache.h <span style="color: grey">(60d370de)</span></li>
<li>src/file/regexpcache.cpp <span style="color: grey">(61f07d61)</span></li>
<li>src/file/xattrindexer.cpp <span style="color: grey">(3daecef6)</span></li>
<li>src/kioslaves/timeline/timelinetools.cpp <span style="color: \
grey">(26e44ee8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129349/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8027707297312679331==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic