'Re: Review Request 129650: [baloo] Remove useless includes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 129650: [baloo] Remove useless includes
From:       Christian Ehrlicher <ch.ehrlicher () gmx ! de>
Date:       2017-08-23 17:20:26
Message-ID: 20170823172026.20412.32412 () mimi ! kde ! org
[Download RAW message or body]

--===============1056784057472222094==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129650/
-----------------------------------------------------------

(Updated Aug. 23, 2017, 7:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo.


Changes
-------

Submitted with commit 1ba4c1375ba74d6eb61f70d7215ed160735d269e by Christian Ehrlicher \
to branch master.


Repository: baloo


Description
-------

In mainadaptor there are a lot of useless forward declarations and includes - don't \
know why and therefore a review request here :) It's no public API so this shouldn't \
be an argument.


Diffs
-----

  src/file/mainadaptor.h b5c8bd3 
  src/file/mainadaptor.cpp 933b1d0 

Diff: https://git.reviewboard.kde.org/r/129650/diff/


Testing
-------


Thanks,

Christian Ehrlicher


--===============1056784057472222094==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129650/">https://git.reviewboard.kde.org/r/129650/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Christian Ehrlicher.</div>


<p style="color: grey;"><i>Updated Aug. 23, 2017, 7:20 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1ba4c1375ba74d6eb61f70d7215ed160735d269e by \
Christian Ehrlicher to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In mainadaptor there are a lot of useless forward \
declarations and includes - don't know why and therefore a review request here :) \
It's no public API so this shouldn't be an argument.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/mainadaptor.h <span style="color: grey">(b5c8bd3)</span></li>

 <li>src/file/mainadaptor.cpp <span style="color: grey">(933b1d0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129650/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1056784057472222094==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic