[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Merging KMag frameworks branch to master
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2017-03-08 14:23:42
Message-ID: CADWV2K6MKHyjoc7VcPTS1nqfED=mMuLOh1C8Cwy+41xbPOK_Ag () mail ! gmail ! com
[Download RAW message or body]
Hi Ben,
It looks like that wont be needed actually. I had moved it to phabricator,
just with a non obvious name. Here's my irc log:
[Tuesday, September 1, 2015] [5:54:21 PM MDT] <jpwhiting> kdepepo: is
kaccessible needed for kmag (or anything else) in Qt5/kf5 setup ?
[Tuesday, September 1, 2015] [5:54:49 PM MDT] <jpwhiting> and what's the
state of the kmag frameworks branch? is it "done" just needs merging or are
there issues to fix still ?
[Tuesday, September 1, 2015] [5:57:32 PM MDT] <kdepepo> jpwhiting, not sure
about kaccessible ... as far as I know, kmag links to qaccessibleclient,
which is a lib in playground
[Tuesday, September 1, 2015] [5:58:56 PM MDT] <kdepepo> issues:
https://paste.kde.org/pgvbptjnd
[Tuesday, September 1, 2015] [6:10:35 PM MDT] <jpwhiting> hmm? which X11
includes are missing for kmousetool ?
[Tuesday, September 1, 2015] [6:10:42 PM MDT] <jpwhiting> I built it here
last week, /me looks
[Tuesday, September 1, 2015] [6:11:42 PM MDT] <jpwhiting> kdepepo: ^^
[Tuesday, September 1, 2015] [6:12:22 PM MDT] <kdepepo> I don't remember
exactly, but I think shumski complained
[Tuesday, September 1, 2015] [6:12:45 PM MDT] <jpwhiting> k, I'll ask him
[Tuesday, September 1, 2015] [6:12:47 PM MDT] <jpwhiting> thanks
[Tuesday, September 1, 2015] [6:15:23 PM MDT] <kdepepo> jpwhiting, looking
at my changes, I have a find_package(X11) there, but nothing which adds the
X11 include dirs to the include path.
[Tuesday, September 1, 2015] [6:16:22 PM MDT] <jpwhiting>
target_link_libraries should be adding include paths now iirc
[Tuesday, September 1, 2015] [6:16:37 PM MDT] <kdepepo> hm, and it actually
only needs libXtst, not X11 ... not sure if the cmake stuff is correct
[Tuesday, September 1, 2015] [6:17:18 PM MDT] <jpwhiting> ah, probably
doesn't need all of the ${X11_LIBRARIES} then?
[Tuesday, September 1, 2015] [7:21:55 PM MDT] <jpwhiting> kdepepo: I'm
beginning to think that either a todo.kde.org or a workboard on phabricator
would be good to track what is left to d
o re porting to Qt5/kf5
[Tuesday, September 1, 2015] [7:22:19 PM MDT] <jpwhiting>
http://developer.kde.org/~cfeck/portingstatus.html is good, but only shows
what's been merged/committed, not what's in progress a
nd by whom
[Friday, September 4, 2015] [2:15:52 PM MDT] <kde__pepo> removing the
fixx11 include compiles without errors.
[Friday, September 4, 2015] [2:16:00 PM MDT] <jpwhiting> ok, ship it! :)
[Friday, September 4, 2015] [2:17:24 PM MDT] <pursuivant> ^Bkmousetool^B
^C5(frameworks)^C ^C12v15.04.1-10-gac639c4^C * ^C3Christoph Feck^C:
kmousetool/kmousetool.cpp
[Friday, September 4, 2015] [2:17:24 PM MDT] <pursuivant> Remove obsolete
#include <fixx11h.h>
[Friday, September 4, 2015] [2:17:25 PM MDT] <pursuivant>
http://commits.kde.org/kmousetool/ac639c429b209bb95beb0d3c79ffa18cc470b452
[Friday, September 4, 2015] [2:18:09 PM MDT] Quit pursuivant
(pursuivant@kde/bot/commit-notifications) has left this server (Quit:
transmission timeout).
[Friday, September 4, 2015] [2:18:33 PM MDT] <kde__pepo> I haven't had
time yet to check how the reverse AA scaler can be added to kmag.
[Friday, September 4, 2015] [2:19:02 PM MDT] <kde__pepo> Currently it
simply zooms by setting a scale matrix.
[Friday, September 4, 2015] [2:19:15 PM MDT] <jpwhiting> I suggest we
add it to the kmag TODO file if it has one, but I don't think that should
block frameworks getting merged to master
[Friday, September 4, 2015] [2:19:16 PM MDT] <jpwhiting> imo
[Friday, September 4, 2015] [2:19:40 PM MDT] <kde__pepo> right, what I
posted was my todo list :P
[Friday, September 4, 2015] [2:19:44 PM MDT] <jpwhiting> ah, ok
[Friday, September 4, 2015] [2:20:07 PM MDT] <jpwhiting> I started
putting your todo list on https://phabricator.kde.org/tag/qt_5_porting/ :)
[Friday, September 4, 2015] [2:21:18 PM MDT] <kde__pepo> kmag mode not
saved is bug 332303
[Friday, September 4, 2015] [2:24:40 PM MDT] <jpwhiting> k, added
So tldr the list is alive here:
https://phabricator.kde.org/tag/qt_5_porting/
thanks,
Jeremy
On Mon, Mar 6, 2017 at 11:45 PM, Ben Cooksley <bcooksley@kde.org> wrote:
> On Tue, Mar 7, 2017 at 4:19 PM, Jeremy Whiting <jpwhiting@kde.org> wrote:
> > It looks like todo.kde.org is down or no longer a thing. I thought I
> moved
> > the list to phabricator, but can't seem to find it on there either.
>
> Hi Jeremy,
>
> todo.kde.org was phased out a while back after a notified period for
> migrations.
> Sysadmin have since archived the site in long term storage.
>
> If necessary we can probably bring it online temporarily in order for
> a migration to Phabricator to be made for these tasks.
> Please file a Sysadmin task if we need to do that.
>
> Cheers,
> Ben
>
> >
> > On Mon, Mar 6, 2017 at 2:56 PM, Albert Astals Cid <aacid@kde.org> wrote:
> >>
> >> El dilluns, 6 de març de 2017, a les 1:29:32 CET, Christoph Feck va
> >> escriure:
> >> > On 05.03.2017 23:59, Albert Astals Cid wrote:
> >> > > I had a quick look and features seem to work as good/bad in the
> >> > > frameworks
> >> > > branch as in master.
> >> > >
> >> > > If noone disagrees I'll do the merge on March 13th.
> >> >
> >> > Jeremy Whiting had a list somewhere on todo.kde.org with tasks that
> >> > blocked merging. I only remember two, because I was responsible for
> >> > them, but I think there were more.
> >>
> >> Does anyone have a link to that list? Wouldn't want to force a merge
> >> that's
> >> not ready :)
> >>
> >> Cheers,
> >> Albert
> >>
> >> >
> >> > First, I did not correctly port the saving to remote image via KIO.
> >> > Someone familiar with KIO could look at
> >> >
> >> > https://cgit.kde.org/kmag.git/commit/?h=frameworks&id=
> daa05153573ace5bb76479
> >> > 71a7a21dc724777a4f and correct it.
> >> >
> >> > Second,
> >> >
> >> > https://cgit.kde.org/kmag.git/commit/?h=frameworks&id=
> 1f8e4208d72c7f9ce6fa73
> >> > 9f477151aab1fadccf enabled building against QAccessibilityClient, but
> I
> >> > could not test it.
> >>
> >>
> >
>
[Attachment #3 (text/html)]
<div dir="ltr">Hi Ben,<div><br></div><div>It looks like that wont be needed \
actually. I had moved it to phabricator, just with a non obvious name. \
Here's my irc log:<br><div><br></div><div><span \
style="font-family:monospace"><span style="color:rgb(0,0,0)">[Tuesday, \
September 1, 2015] [5:54:21 PM MDT] <jpwhiting> kdepepo: is \
kaccessible needed for kmag (or anything else) in Qt5/kf5 setup ? \
</span><br>[Tuesday, September 1, 2015] [5:54:49 PM MDT] <jpwhiting> \
and what's the state of the kmag frameworks branch? is it \
"done" just needs merging or are there issues to fix still ? \
<br>[Tuesday, September 1, 2015] [5:57:32 PM MDT] <kdepepo> \
jpwhiting, not sure about kaccessible ... as far as I know, kmag links to \
qaccessibleclient, which is a lib in playground <br>[Tuesday, September 1, \
2015] [5:58:56 PM MDT] <kdepepo> issues: <a \
href="https://paste.kde.org/pgvbptjnd">https://paste.kde.org/pgvbptjnd</a> \
<br>[Tuesday, September 1, 2015] [6:10:35 PM MDT] <jpwhiting> \
hmm? which X11 includes are missing for kmousetool ? <br>[Tuesday, \
September 1, 2015] [6:10:42 PM MDT] <jpwhiting> I built it here \
last week, /me looks <br>[Tuesday, September 1, 2015] [6:11:42 PM MDT] \
<jpwhiting> kdepepo: ^^ <br><span \
style="color:rgb(0,0,0);background-color:rgb(24,178,178)">[</span><span \
style="color:rgb(0,0,0)">Tuesday, September 1, 2015</span><span \
style="color:rgb(0,0,0);background-color:rgb(24,178,178)">]</span><span \
style="color:rgb(0,0,0)"> [6:12:22 PM MDT] <kdepepo> I don't \
remember exactly, but I think shumski complained </span><br>[Tuesday, \
September 1, 2015] [6:12:45 PM MDT] <jpwhiting> k, I'll ask \
him <br>[Tuesday, September 1, 2015] [6:12:47 PM MDT] <jpwhiting> \
thanks <br>[Tuesday, September 1, 2015] [6:15:23 PM MDT] <kdepepo> \
jpwhiting, looking at my changes, I have a find_package(X11) there, but \
nothing which adds the X11 include dirs to the include path. <br>[Tuesday, \
September 1, 2015] [6:16:22 PM MDT] <jpwhiting> \
target_link_libraries should be adding include paths now iirc <br>[Tuesday, \
September 1, 2015] [6:16:37 PM MDT] <kdepepo> hm, and it actually \
only needs libXtst, not X11 ... not sure if the cmake stuff is correct \
<br>[Tuesday, September 1, 2015] [6:17:18 PM MDT] <jpwhiting> ah, \
probably doesn't need all of the ${X11_LIBRARIES} then? <br>[Tuesday, \
September 1, 2015] [7:21:55 PM MDT] <jpwhiting> kdepepo: I'm \
beginning to think that either a <a \
href="http://todo.kde.org">todo.kde.org</a> or a workboard on phabricator \
would be good to track what is left to d<br>o re porting to Qt5/kf5 \
<br>[Tuesday, September 1, 2015] [7:22:19 PM MDT] <jpwhiting> <a \
href="http://developer.kde.org/~cfeck/portingstatus.html">http://developer.kde.org/~cfeck/portingstatus.html</a> \
is good, but only shows what's been merged/committed, not what's in \
progress a<br>nd by whom<br> </span><span \
style="font-family:monospace"><span style="color:rgb(0,0,0)">[Friday, \
September 4, 2015] [2:15:52 PM MDT] <kde__pepo> removing the \
fixx11 include compiles without errors. </span><br>[Friday, September 4, \
2015] [2:16:00 PM MDT] <jpwhiting> ok, ship it! :) <br>[Friday, \
September 4, 2015] [2:17:24 PM MDT] <pursuivant> <span \
style="color:rgb(95,215,255)">^B</span><span \
style="color:rgb(0,0,0)">kmousetool</span><span \
style="color:rgb(95,215,255)">^B</span><span style="color:rgb(0,0,0)"> \
</span><span style="color:rgb(95,215,255)">^C</span><span \
style="color:rgb(0,0,0)">5(frameworks)</span><span \
style="color:rgb(95,215,255)">^C</span><span style="color:rgb(0,0,0)"> \
</span><span style="color:rgb(95,215,255)">^C</span><span \
style="color:rgb(0,0,0)">12v15.04.1-10-gac639c4</span><span \
style="color:rgb(95,215,255)">^C</span><span style="color:rgb(0,0,0)"> * \
</span><span style="color:rgb(95,215,255)">^C</span><span \
style="color:rgb(0,0,0)">3Christoph Feck</span><span \
style="color:rgb(95,215,255)">^C</span><span style="color:rgb(0,0,0)">: \
kmousetool/kmousetool.cpp </span><br>[Friday, September 4, 2015] [2:17:24 \
PM MDT] <pursuivant> Remove obsolete #include <fixx11h.h> \
<br>[Friday, September 4, 2015] [2:17:25 PM MDT] <pursuivant> <a \
href="http://commits.kde.org/kmousetool/ac639c429b209bb95beb0d3c79ffa18cc470 \
b452">http://commits.kde.org/kmousetool/ac639c429b209bb95beb0d3c79ffa18cc470b452</a>
<br>[Friday, September 4, 2015] [2:18:09 PM MDT] Quit pursuivant \
(pursuivant@kde/bot/commit-notifications) has left this server (Quit: \
transmission timeout). <br>[Friday, September 4, 2015] [2:18:33 PM MDT] \
<kde__pepo> I haven't had time yet to check how the reverse \
AA scaler can be added to kmag. <br>[Friday, September 4, 2015] [2:19:02 PM \
MDT] <kde__pepo> Currently it simply zooms by setting a scale \
matrix. <br>[Friday, September 4, 2015] [2:19:15 PM MDT] <jpwhiting> \
I suggest we add it to the kmag TODO file if it has one, but I don't \
think that should block frameworks getting merged to master <br>[Friday, \
September 4, 2015] [2:19:16 PM MDT] <jpwhiting> imo \
<br>[Friday, September 4, 2015] [2:19:40 PM MDT] <kde__pepo> \
right, what I posted was my todo list :P <br>[Friday, September 4, 2015] \
[2:19:44 PM MDT] <jpwhiting> ah, ok <br>[Friday, September 4, \
2015] [2:20:07 PM MDT] <jpwhiting> I started putting your todo \
list on <a href="https://phabricator.kde.org/tag/qt_5_porting/">https://phabricator.kde.org/tag/qt_5_porting/</a> \
:) <br>[Friday, September 4, 2015] [2:21:18 PM MDT] <kde__pepo> \
kmag mode not saved is bug 332303 <br>[Friday, September 4, 2015] [2:24:40 \
PM MDT] <jpwhiting> k, added<br> <br></span></div><div><span \
style="font-family:monospace">So tldr the list is alive here: </span><span \
style="font-family:monospace"><a \
href="https://phabricator.kde.org/tag/qt_5_porting/">https://phabricator.kde.org/tag/qt_5_porting/</a></span></div><div><br></div><div><font \
face="monospace">thanks,</font></div><div><font \
face="monospace">Jeremy</font></div></div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 6, 2017 at \
11:45 PM, Ben Cooksley <span dir="ltr"><<a \
href="mailto:bcooksley@kde.org" \
target="_blank">bcooksley@kde.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On Tue, Mar 7, 2017 at 4:19 PM, \
Jeremy Whiting <<a \
href="mailto:jpwhiting@kde.org">jpwhiting@kde.org</a>> wrote:<br> > \
It looks like <a href="http://todo.kde.org" rel="noreferrer" \
target="_blank">todo.kde.org</a> is down or no longer a thing. I thought I \
moved<br> > the list to phabricator, but can't seem to find it on \
there either.<br> <br>
</span>Hi Jeremy,<br>
<br>
<a href="http://todo.kde.org" rel="noreferrer" \
target="_blank">todo.kde.org</a> was phased out a while back after a \
notified period for migrations.<br> Sysadmin have since archived the site \
in long term storage.<br> <br>
If necessary we can probably bring it online temporarily in order for<br>
a migration to Phabricator to be made for these tasks.<br>
Please file a Sysadmin task if we need to do that.<br>
<br>
Cheers,<br>
Ben<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> On Mon, Mar 6, 2017 at 2:56 PM, Albert Astals Cid <<a \
href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br> >><br>
>> El dilluns, 6 de març de 2017, a les 1:29:32 CET, Christoph Feck \
va<br> >> escriure:<br>
>> > On 05.03.2017 23:59, Albert Astals Cid wrote:<br>
>> > > I had a quick look and features seem to work as good/bad \
in the<br> >> > > frameworks<br>
>> > > branch as in master.<br>
>> > ><br>
>> > > If noone disagrees I'll do the merge on March \
13th.<br> >> ><br>
>> > Jeremy Whiting had a list somewhere on <a \
href="http://todo.kde.org" rel="noreferrer" \
target="_blank">todo.kde.org</a> with tasks that<br> >> > blocked \
merging. I only remember two, because I was responsible for<br> >> \
> them, but I think there were more.<br> >><br>
>> Does anyone have a link to that list? Wouldn't want to force a \
merge<br> >> that's<br>
>> not ready :)<br>
>><br>
>> Cheers,<br>
>> Albert<br>
>><br>
>> ><br>
>> > First, I did not correctly port the saving to remote image \
via KIO.<br> >> > Someone familiar with KIO could look at<br>
>> ><br>
>> > <a href="https://cgit.kde.org/kmag.git/commit/?h=frameworks&id=daa05153573ace5bb76479" \
rel="noreferrer" target="_blank">https://cgit.kde.org/kmag.git/<wbr>commit/?h=frameworks&id=<wbr>daa05153573ace5bb76479</a><br>
>> > 71a7a21dc724777a4f and correct it.<br>
>> ><br>
>> > Second,<br>
>> ><br>
>> > <a href="https://cgit.kde.org/kmag.git/commit/?h=frameworks&id=1f8e4208d72c7f9ce6fa73" \
rel="noreferrer" target="_blank">https://cgit.kde.org/kmag.git/<wbr>commit/?h=frameworks&id=<wbr>1f8e4208d72c7f9ce6fa73</a><br>
>> > 9f477151aab1fadccf enabled building against \
QAccessibilityClient, but I<br> >> > could not test it.<br>
>><br>
>><br>
><br>
</div></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic