[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117436: Doesn't assume that the users home directory is under /home
From: Lindsay Mathieson <lindsay.mathieson () gmail ! com>
Date: 2017-02-26 0:04:29
Message-ID: 20170226000429.3284.1238 () mimi ! kde ! org
[Download RAW message or body]
--===============1052277849771125784==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117436/
-----------------------------------------------------------
(Updated Feb. 26, 2017, 12:04 a.m.)
Status
------
This change has been discarded.
Review request for Baloo.
Repository: baloo
Description
-------
Part of the KCM code assumes the users home dir is under "/home", which is not always \
the cause in linux - e.g OpenSUSE with AD Authentication uses a /home/DOMAIN \
hierarchy. Other systems use /opt. Not to mention windows etc.
The code adds a function homeRoot() which returns the parent directory of the uses \
home directory.
Diffs
-----
src/file/kcm/folderselectionwidget.cpp bc87a33
Diff: https://git.reviewboard.kde.org/r/117436/diff/
Testing
-------
Built, installed. Adding paths to the exclude lists still recognise the home root.
Thanks,
Lindsay Mathieson
--===============1052277849771125784==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117436/">https://git.reviewboard.kde.org/r/117436/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2017, 12:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Part of the KCM code assumes the users home dir is under \
"/home", which is not always the cause in linux - e.g OpenSUSE with AD \
Authentication uses a /home/DOMAIN hierarchy. Other systems use /opt. Not to mention \
windows etc.
The code adds a function homeRoot() which returns the parent directory of the uses \
home directory.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built, installed. Adding paths to the exclude lists still recognise the \
home root.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117436/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1052277849771125784==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic