[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 128665: Nested tags for Baloo Widgets
From: James Smith <smithjd15 () gmail ! com>
Date: 2017-02-19 20:10:58
Message-ID: 20170219201058.5339.86845 () mimi ! kde ! org
[Download RAW message or body]
--===============1043278475321548914==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128665/
-----------------------------------------------------------
(Updated Feb. 19, 2017, 8:10 p.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo.
Changes
-------
Submitted with commit 0a2c8177439770f5a69826abebda1a53d26078a5 by James D. Smith to \
branch master.
Bugs: 334615
http://bugs.kde.org/show_bug.cgi?id=334615
Repository: baloo-widgets
Description
-------
Info pane tags are shortened to their last element, with the full tag shown in each \
tag's tooltip. The tag selector box allows for creating and selecting nested tags.
Diffs
-----
src/kedittagsdialog.cpp 1778d53
src/kedittagsdialog_p.h 3c4de19
src/tagcheckbox.cpp 8273a7f
Diff: https://git.reviewboard.kde.org/r/128665/diff/
Testing
-------
Compile, run
File Attachments
----------------
Edit Tags Dialog
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png
Thanks,
James Smith
--===============1043278475321548914==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128665/">https://git.reviewboard.kde.org/r/128665/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2017, 8:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 0a2c8177439770f5a69826abebda1a53d26078a5 by James \
D. Smith to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334615">334615</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo-widgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Info pane tags are shortened to their last element, \
with the full tag shown in each tag's tooltip. The tag selector box allows for \
creating and selecting nested tags.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kedittagsdialog.cpp <span style="color: grey">(1778d53)</span></li>
<li>src/kedittagsdialog_p.h <span style="color: grey">(3c4de19)</span></li>
<li>src/tagcheckbox.cpp <span style="color: grey">(8273a7f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128665/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/b572b577-0931-40c5-a6d9-6dd655b0f1b6__baloonestedtagwidget.png">Edit \
Tags Dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1043278475321548914==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic