[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepac
From: Matthieu Gallien <matthieu_gallien () yahoo ! fr>
Date: 2017-02-05 15:30:06
Message-ID: 20170205153006.26007.64716 () mimi ! kde ! org
[Download RAW message or body]
--===============7202944219844349484==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129798/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 4:30 p.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo and KDE Frameworks.
Changes
-------
Submitted with commit 35ea63920a0398aa859b2944770fd9036c271166 by Matthieu Gallien to \
branch master.
Repository: kfilemetadata
Description
-------
Musepack extraction of album artist was using the wrong tag name (tested
against easytag and picard).
See also this page (http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) that seems \
to indicate that APE is using "ALBUM ARTIST" with a space between both words.
Diffs
-----
autotests/samplefiles/test.flac PRE-CREATION
autotests/samplefiles/test.m4a PRE-CREATION
autotests/samplefiles/test.mp3 PRE-CREATION
autotests/samplefiles/test.mpc PRE-CREATION
autotests/samplefiles/test.ogg PRE-CREATION
autotests/taglibextractortest.cpp d46e49e
src/extractors/taglibextractor.cpp 8fcad93
Diff: https://git.reviewboard.kde.org/r/129798/diff/
Testing
-------
I have tested with automatic tests of KFileMetaData and also the encoding problem in \
Musepack format against Easytag and Picard applications.
Thanks,
Matthieu Gallien
--===============7202944219844349484==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129798/">https://git.reviewboard.kde.org/r/129798/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and KDE Frameworks.</div>
<div>By Matthieu Gallien.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2017, 4:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 35ea63920a0398aa859b2944770fd9036c271166 by \
Matthieu Gallien to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Musepack extraction of album artist was using the \
wrong tag name (tested against easytag and picard).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See also this page \
(http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) that seems to indicate that \
APE is using "ALBUM ARTIST" with a space between both words.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have tested with automatic tests of KFileMetaData \
and also the encoding problem in Musepack format against Easytag and Picard \
applications.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/samplefiles/test.flac <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.m4a <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.mp3 <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.mpc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/samplefiles/test.ogg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/taglibextractortest.cpp <span style="color: \
grey">(d46e49e)</span></li>
<li>src/extractors/taglibextractor.cpp <span style="color: \
grey">(8fcad93)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129798/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7202944219844349484==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic