[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 129605: Move the Baloo database into the XDG cache path.
From: Matthieu Gallien <matthieu_gallien () yahoo ! fr>
Date: 2017-02-05 13:08:41
Message-ID: 20170205130841.26007.51503 () mimi ! kde ! org
[Download RAW message or body]
--===============7638853243596777621==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 4, 2017, 7:59 p.m., Albert Astals Cid wrote:
> > Any reason this has not been commited?
>
> Luigi Toscano wrote:
> Because there was no final decision.
>
> It is true that the Baloo database can be regenerated, but I would say that if we \
> avoid a complete rebuild of the database after a Frameworks update, that would be \
> good.
> Would it be better to read the old location if found and reserve the new one only \
> for new database (or rebuilt) and switch to the new one for Frameworks 6?
> James Smith wrote:
> Regeneratable data isn't config, so this change isn't as important as the config \
> location change between SC4 and KF5. The config data location switch was mandatory \
> for KF5-based apps. I think we can safely switch regeneratable data at any time.
> Luigi Toscano wrote:
> Did you try it in practice? I'm talking about time and I/O which is not visibile in \
> the normal usage because the full indexing already happened. Moreover the old index \
> will be left there unused.
> James Smith wrote:
> A 64069 file reindex for me took ~58 mins. An update of eg. Calligra shouldn't be \
> done when there is an immediate requirement to use Calligra, likewise an update of \
> Baloo shouldn't be attempted when there is expected use of Baloo in the immediate \
> future; don't fix it if it isn't broken. There has been a suggestion to group \
> patches that require a reindex, thereby lessening any reindexing caused by \
> upgrading Baloo.
> The old index would be left there unused whether the patch is waited on for KF5's \
> successor or otherwise.
> Luigi Toscano wrote:
> It does not work like that. Distributions like Fedora, Archlinux, or Gentoo, and \
> also Debian unstable, upgrades the Frameworks packages frequently, so their users \
> will be impacted.
> It is more expected to have leftovers with a major upgrade, but nevertheless it \
> would be good to have a migration.
> So to summarize I think that:
> - the old location should be used if available, or
> - if a migration should be forced, the data should be moved (in an async way - is \
> there anything that prevent that? Could it happen that they are on different \
> drives?)
As a related fact, I have two pending review requests (#129839 and #129798) on \
KFileMetaData that may require reindexing audio files. Not sure there is a good way \
to do that but definitely related to Baloo migration issues.
- Matthieu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129605/#review102382
-----------------------------------------------------------
On Dec. 12, 2016, 12:06 p.m., James Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129605/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 12:06 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Move the database into the XDG cache path.
>
>
> Diffs
> -----
>
> src/engine/global.cpp 4f511ac08f0fd18bd3c78b794f4ba7ccef88e75b
> src/tools/balooctl/main.cpp 2a6b175ee599d7ca713adcbed80d3bd128e9dd63
>
> Diff: https://git.reviewboard.kde.org/r/129605/diff/
>
>
> Testing
> -------
>
> Compile, run.
>
>
> Thanks,
>
> James Smith
>
>
--===============7638853243596777621==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129605/">https://git.reviewboard.kde.org/r/129605/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 4th, 2017, 7:59 p.m. CET, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Any reason this has not been commited?</p></pre> \
</blockquote>
<p>On February 4th, 2017, 8:04 p.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Because there was no final decision.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is \
true that the Baloo database can be regenerated, but I would say that if we avoid a \
complete rebuild of the database after a Frameworks update, that would be good.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Would it be better to read the old location if found \
and reserve the new one only for new database (or rebuilt) and switch to the new one \
for Frameworks 6?</p></pre> </blockquote>
<p>On February 5th, 2017, 12:22 a.m. CET, <b>James Smith</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Regeneratable data isn't config, so this change isn't as important as the \
config location change between SC4 and KF5. The config data location switch was \
mandatory for KF5-based apps. I think we can safely switch regeneratable data at any \
time.</p></pre> </blockquote>
<p>On February 5th, 2017, 12:29 a.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did \
you try it in practice? I'm talking about time and I/O which is not visibile in the \
normal usage because the full indexing already happened. Moreover the old index will \
be left there unused.</p></pre> </blockquote>
<p>On February 5th, 2017, 2:53 a.m. CET, <b>James Smith</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A \
64069 file reindex for me took ~58 mins. An update of eg. Calligra shouldn't be done \
when there is an immediate requirement to use Calligra, likewise an update of Baloo \
shouldn't be attempted when there is expected use of Baloo in the immediate future; \
don't fix it if it isn't broken. There has been a suggestion to group patches that \
require a reindex, thereby lessening any reindexing caused by upgrading Baloo.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The old index would be left there unused whether the patch is waited on for \
KF5's successor or otherwise.</p></pre> </blockquote>
<p>On February 5th, 2017, 1:16 p.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
does not work like that. Distributions like Fedora, Archlinux, or Gentoo, and also \
Debian unstable, upgrades the Frameworks packages frequently, so their users will be \
impacted.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It is more expected to have leftovers with a major \
upgrade, but nevertheless it would be good to have a migration.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">So to summarize I think that:
- the old location should be used if available, or
- if a migration should be forced, the data should be moved (in an async way - is \
there anything that prevent that? Could it happen that they are on different \
drives?)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As a \
related fact, I have two pending review requests (#129839 and #129798) on \
KFileMetaData that may require reindexing audio files. Not sure there is a good way \
to do that but definitely related to Baloo migration issues.</p></pre> <br />
<p>- Matthieu</p>
<br />
<p>On December 12th, 2016, 12:06 p.m. CET, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2016, 12:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Move the database into the XDG cache path.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compile, run.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/global.cpp <span style="color: \
grey">(4f511ac08f0fd18bd3c78b794f4ba7ccef88e75b)</span></li>
<li>src/tools/balooctl/main.cpp <span style="color: \
grey">(2a6b175ee599d7ca713adcbed80d3bd128e9dd63)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129605/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7638853243596777621==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic