[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 129349: [baloo] add (and use) FileIndexerConfig::shouldFileBeIndexed(const QStrin
From: Christian Ehrlicher <ch.ehrlicher () gmx ! de>
Date: 2016-12-13 5:44:09
Message-ID: 20161213054409.16852.13907 () mimi ! kde ! org
[Download RAW message or body]
--===============1536526279206605971==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dez. 13, 2016, 3:08 vorm., Aleix Pol Gonzalez wrote:
> > src/kioslaves/timeline/timelinetools.cpp, line 98
> > <https://git.reviewboard.kde.org/r/129349/diff/2/?file=487336#file487336line98>
> >
> > Use `split(QLatin1Char('/'),...)`
> > Also this can be changed into splitRef?
I thought about this too but since s_dateRegexp is a QRegExp (and not a \
QRegularExpression) I thought that the outcome is not worth the change. Maybe I \
should change s_dateRegexp to a QRegularExpression ...
- Christian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129349/#review101405
-----------------------------------------------------------
On Dez. 12, 2016, 6:48 nachm., Christian Ehrlicher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129349/
> -----------------------------------------------------------
>
> (Updated Dez. 12, 2016, 6:48 nachm.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Use the new QStringRef class to avoid creation of temporary QString objects.
> Since every filename is sent through FileIndexerConfig::shouldFileBeIndexed(), I \
> think this is a good optimization although now there are two functions for \
> FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one with \
> QString and one with QStringRef ...
>
> Diffs
> -----
>
> src/engine/queryparser.cpp d096bf3
> src/file/fileindexerconfig.h 10eacd5
> src/file/fileindexerconfig.cpp 0e4f4c4
> src/file/modifiedfileindexer.cpp d1f5011
> src/file/newfileindexer.cpp 7e19622
> src/file/regexpcache.h 60d370d
> src/file/regexpcache.cpp 61f07d6
> src/file/xattrindexer.cpp 3daecef
> src/kioslaves/tags/kio_tags.cpp de2e6d7
> src/kioslaves/timeline/timelinetools.cpp 26e44ee
>
> Diff: https://git.reviewboard.kde.org/r/129349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christian Ehrlicher
>
>
--===============1536526279206605971==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129349/">https://git.reviewboard.kde.org/r/129349/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Dezember 13th, 2016, 3:08 vorm. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129349/diff/2/?file=487336#file487336line98" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kioslaves/timeline/timelinetools.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">98</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QStringList</span> <span class="n">sections</span> <span class="o">=</span> \
<span class="n">path</span><span class="p">.</span><span class="n">split</span><span \
class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"/"</span><span class="p">),</span> <span \
class="n">QString</span><span class="o">::</span><span \
class="n">SkipEmptyParts</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">98</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="hl"> </span><span class="k"><span class="hl">const</span></span> <span \
class="n">QStringList</span> <span class="n">sections</span> <span class="o">=</span> \
<span class="n">path</span><span class="p">.</span><span class="n">split</span><span \
class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"/"</span><span class="p">),</span> <span \
class="n">QString</span><span class="o">::</span><span \
class="n">SkipEmptyParts</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">split(QLatin1Char('/'),...)</code> Also this \
can be changed into splitRef?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I thought about this too but since s_dateRegexp is a QRegExp (and not a \
QRegularExpression) I thought that the outcome is not worth the change. Maybe I \
should change s_dateRegexp to a QRegularExpression ...</p></pre> <br />
<p>- Christian</p>
<br />
<p>On Dezember 12th, 2016, 6:48 nachm. UTC, Christian Ehrlicher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Christian Ehrlicher.</div>
<p style="color: grey;"><i>Updated Dez. 12, 2016, 6:48 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use the new QStringRef class to avoid creation of \
temporary QString objects. Since every filename is sent through \
FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization \
although now there are two functions for FileIndexerConfig::shouldFileBeIndexed() and \
RegExpCache::exactMatch() - one with QString and one with QStringRef ...</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/queryparser.cpp <span style="color: grey">(d096bf3)</span></li>
<li>src/file/fileindexerconfig.h <span style="color: grey">(10eacd5)</span></li>
<li>src/file/fileindexerconfig.cpp <span style="color: grey">(0e4f4c4)</span></li>
<li>src/file/modifiedfileindexer.cpp <span style="color: grey">(d1f5011)</span></li>
<li>src/file/newfileindexer.cpp <span style="color: grey">(7e19622)</span></li>
<li>src/file/regexpcache.h <span style="color: grey">(60d370d)</span></li>
<li>src/file/regexpcache.cpp <span style="color: grey">(61f07d6)</span></li>
<li>src/file/xattrindexer.cpp <span style="color: grey">(3daecef)</span></li>
<li>src/kioslaves/tags/kio_tags.cpp <span style="color: grey">(de2e6d7)</span></li>
<li>src/kioslaves/timeline/timelinetools.cpp <span style="color: \
grey">(26e44ee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129349/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1536526279206605971==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic