'Re: Review Request 129349: [baloo] add (and use) FileIndexerConfig::shouldFileBeIndexed(const QStrin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 129349: [baloo] add (and use) FileIndexerConfig::shouldFileBeIndexed(const QStrin
From:       Christian Ehrlicher <ch.ehrlicher () gmx ! de>
Date:       2016-12-12 18:48:22
Message-ID: 20161212184822.16852.9083 () mimi ! kde ! org
[Download RAW message or body]

--===============3426603608125099115==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129349/
-----------------------------------------------------------

(Updated Dec. 12, 2016, 6:48 p.m.)


Review request for Baloo.


Changes
-------

Updated diff to fix issues


Repository: baloo


Description
-------

Use the new QStringRef class to avoid creation of temporary QString objects.
Since every filename is sent through FileIndexerConfig::shouldFileBeIndexed(), I \
think this is a good optimization although now there are two functions for \
FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one with \
QString and one with QStringRef ...


Diffs (updated)
-----

  src/engine/queryparser.cpp d096bf3 
  src/file/fileindexerconfig.h 10eacd5 
  src/file/fileindexerconfig.cpp 0e4f4c4 
  src/file/modifiedfileindexer.cpp d1f5011 
  src/file/newfileindexer.cpp 7e19622 
  src/file/regexpcache.h 60d370d 
  src/file/regexpcache.cpp 61f07d6 
  src/file/xattrindexer.cpp 3daecef 
  src/kioslaves/tags/kio_tags.cpp de2e6d7 
  src/kioslaves/timeline/timelinetools.cpp 26e44ee 

Diff: https://git.reviewboard.kde.org/r/129349/diff/


Testing
-------


Thanks,

Christian Ehrlicher


--===============3426603608125099115==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129349/">https://git.reviewboard.kde.org/r/129349/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Christian Ehrlicher.</div>


<p style="color: grey;"><i>Updated Dec. 12, 2016, 6:48 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Updated diff to fix issues</p></pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use the new QStringRef class to avoid creation of \
temporary QString objects. Since every filename is sent through \
FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization \
although now there are two functions for FileIndexerConfig::shouldFileBeIndexed() and \
RegExpCache::exactMatch() - one with QString and one with QStringRef ...</p></pre>  \
</td>  </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/engine/queryparser.cpp <span style="color: grey">(d096bf3)</span></li>

 <li>src/file/fileindexerconfig.h <span style="color: grey">(10eacd5)</span></li>

 <li>src/file/fileindexerconfig.cpp <span style="color: grey">(0e4f4c4)</span></li>

 <li>src/file/modifiedfileindexer.cpp <span style="color: grey">(d1f5011)</span></li>

 <li>src/file/newfileindexer.cpp <span style="color: grey">(7e19622)</span></li>

 <li>src/file/regexpcache.h <span style="color: grey">(60d370d)</span></li>

 <li>src/file/regexpcache.cpp <span style="color: grey">(61f07d6)</span></li>

 <li>src/file/xattrindexer.cpp <span style="color: grey">(3daecef)</span></li>

 <li>src/kioslaves/tags/kio_tags.cpp <span style="color: grey">(de2e6d7)</span></li>

 <li>src/kioslaves/timeline/timelinetools.cpp <span style="color: \
grey">(26e44ee)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129349/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============3426603608125099115==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic