[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 129349: [baloo] add (and use) FileIndexerConfig::shouldFileBeIndexed(const QStrin
From: Aleix Pol Gonzalez <aleixpol () kde ! org>
Date: 2016-12-12 11:18:39
Message-ID: 20161212111839.16852.12162 () mimi ! kde ! org
[Download RAW message or body]
--===============3795398890916811695==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129349/#review101376
-----------------------------------------------------------
+1
src/file/fileindexerconfig.h (line 119)
<https://git.reviewboard.kde.org/r/129349/#comment67874>
You need to duplicate the API documentation.
src/file/fileindexerconfig.cpp (line 188)
<https://git.reviewboard.kde.org/r/129349/#comment67875>
Make this one call the `QStringRef` variant, not to duplicate code?
- Aleix Pol Gonzalez
On Nov. 6, 2016, 2:45 p.m., Christian Ehrlicher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129349/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2016, 2:45 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Use the new QStringRef class to avoid creation of temporary QString objects.
> Since every filename is sent through FileIndexerConfig::shouldFileBeIndexed(), I \
> think this is a good optimization although now there are two functions for \
> FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one with \
> QString and one with QStringRef ...
>
> Diffs
> -----
>
> src/engine/queryparser.cpp d096bf3
> src/file/fileindexerconfig.h 10eacd5
> src/file/fileindexerconfig.cpp 0e4f4c4
> src/file/modifiedfileindexer.cpp d1f5011
> src/file/newfileindexer.cpp 7e19622
> src/file/regexpcache.h 60d370d
> src/file/regexpcache.cpp 61f07d6
> src/file/xattrindexer.cpp 3daecef
> src/kioslaves/tags/kio_tags.cpp de2e6d7
>
> Diff: https://git.reviewboard.kde.org/r/129349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christian Ehrlicher
>
>
--===============3795398890916811695==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129349/">https://git.reviewboard.kde.org/r/129349/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129349/diff/1/?file=484219#file484219line119" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/fileindexerconfig.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">119</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="nf">shouldFileBeIndexed</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QStringRef</span> \
<span class="o">&</span><span class="n">fileName</span><span class="p">)</span> \
<span class="k">const</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
need to duplicate the API documentation.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129349/diff/1/?file=484220#file484220line188" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/fileindexerconfig.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
FileIndexerConfig::shouldFileBeIndexed(const QString& fileName) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">188</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="o">!</span><span \
class="n">indexHiddenFilesAndFolders</span><span class="p">()</span> <span \
class="o">&&</span> <span class="n">fileName</span><span \
class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span \
class="sc">'.'</span><span class="p">))</span> <span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">188</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="o">!</span><span \
class="n">indexHiddenFilesAndFolders</span><span class="p">()</span> <span \
class="o">&&</span> <span class="n">fileName</span><span \
class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span \
class="sc">'.'</span><span class="p">))</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Make \
this one call the <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">QStringRef</code> variant, not \
to duplicate code?</p></pre> </div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On November 6th, 2016, 2:45 p.m. CET, Christian Ehrlicher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Christian Ehrlicher.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2016, 2:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use the new QStringRef class to avoid creation of \
temporary QString objects. Since every filename is sent through \
FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization \
although now there are two functions for FileIndexerConfig::shouldFileBeIndexed() and \
RegExpCache::exactMatch() - one with QString and one with QStringRef ...</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/queryparser.cpp <span style="color: grey">(d096bf3)</span></li>
<li>src/file/fileindexerconfig.h <span style="color: grey">(10eacd5)</span></li>
<li>src/file/fileindexerconfig.cpp <span style="color: grey">(0e4f4c4)</span></li>
<li>src/file/modifiedfileindexer.cpp <span style="color: grey">(d1f5011)</span></li>
<li>src/file/newfileindexer.cpp <span style="color: grey">(7e19622)</span></li>
<li>src/file/regexpcache.h <span style="color: grey">(60d370d)</span></li>
<li>src/file/regexpcache.cpp <span style="color: grey">(61f07d6)</span></li>
<li>src/file/xattrindexer.cpp <span style="color: grey">(3daecef)</span></li>
<li>src/kioslaves/tags/kio_tags.cpp <span style="color: grey">(de2e6d7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129349/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3795398890916811695==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic