[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()
From:       Christian Ehrlicher <ch.ehrlicher () gmx ! de>
Date:       2016-11-07 18:44:45
Message-ID: 20161107184445.6207.46465 () mimi ! kde ! org
[Download RAW message or body]

--===============5284680133141431034==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/
-----------------------------------------------------------

(Updated Nov. 7, 2016, 6:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo, KDE Frameworks and Vishesh Handa.


Changes
-------

Submitted with commit 2717080c46072b2a2998cb7d043a7cbcefa6a843 by Christian Ehrlicher \
to branch master.


Repository: baloo


Description
-------

This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding every \
single encoded int32 to the resulting bytearray which results in a lot of small \
memcpy operations. The idea is to use a preallocated QByteArray and directly encode \
the integers into this buffer. This makes the code a little bit more complex but the \
speedup should be gain enough for this.


Ping! No interest in this patch? Should I discard it?


Diffs
-----

  src/codecs/coding.cpp 5961077 

Diff: https://git.reviewboard.kde.org/r/129186/diff/


Testing
-------

positoncodectest calculates the same md5sum as before.


Thanks,

Christian Ehrlicher


--===============5284680133141431034==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129186/">https://git.reviewboard.kde.org/r/129186/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo, KDE Frameworks and Vishesh Handa.</div>
<div>By Christian Ehrlicher.</div>


<p style="color: grey;"><i>Updated Nov. 7, 2016, 6:44 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 2717080c46072b2a2998cb7d043a7cbcefa6a843 by \
Christian Ehrlicher to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch speeds up PostingCodec::encode() by a \
factor of ~4 by not adding every single encoded int32 to the resulting bytearray \
which results in a lot of small memcpy operations. The idea is to use a preallocated \
QByteArray and directly encode the integers into this buffer. This makes the code a \
little bit more complex but the speedup should be gain enough for this.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Ping! No interest in this patch? Should I discard it?</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">positoncodectest calculates the same md5sum as \
before.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/codecs/coding.cpp <span style="color: grey">(5961077)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129186/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============5284680133141431034==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic