[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT
From: Christian Ehrlicher <ch.ehrlicher () gmx ! de>
Date: 2016-11-06 10:56:23
Message-ID: 20161106105623.6207.83308 () mimi ! kde ! org
[Download RAW message or body]
--===============1891489954287373486==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129183/
-----------------------------------------------------------
(Updated Nov. 6, 2016, 10:56 a.m.)
Status
------
This change has been marked as submitted.
Review request for Baloo.
Changes
-------
Submitted with commit edcda57297a1fc4ff74555afd402cf9c69a2db25 by Christian Ehrlicher \
to branch master.
Repository: baloo
Description
-------
CLayz warns about an unused member var in IOHandler and a missing Q_OBJECT macro in \
TimeEstimator which produces a lot of noise in the compile output.
Ping! No interest in this patch? Should I discard it?
Diffs
-----
src/file/extractor/app.cpp 6843165
src/file/extractor/autotests/iohandlertest.cpp 2c8eeaa
src/file/extractor/iohandler.h c0dfbbb
src/file/extractor/iohandler.cpp b49a2b2
src/file/timeestimator.h 11137d3
Diff: https://git.reviewboard.kde.org/r/129183/diff/
Testing
-------
Compiles fine
Thanks,
Christian Ehrlicher
--===============1891489954287373486==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129183/">https://git.reviewboard.kde.org/r/129183/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Christian Ehrlicher.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2016, 10:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit edcda57297a1fc4ff74555afd402cf9c69a2db25 by \
Christian Ehrlicher to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">CLayz warns about an unused member var in IOHandler \
and a missing Q_OBJECT macro in TimeEstimator which produces a lot of noise in the \
compile output.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Ping! No interest in this patch? Should \
I discard it?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles fine</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/extractor/app.cpp <span style="color: grey">(6843165)</span></li>
<li>src/file/extractor/autotests/iohandlertest.cpp <span style="color: \
grey">(2c8eeaa)</span></li>
<li>src/file/extractor/iohandler.h <span style="color: grey">(c0dfbbb)</span></li>
<li>src/file/extractor/iohandler.cpp <span style="color: grey">(b49a2b2)</span></li>
<li>src/file/timeestimator.h <span style="color: grey">(11137d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129183/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1891489954287373486==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic