[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 128664: Nested tags for Baloo
From: James Smith <smithjd15 () gmail ! com>
Date: 2016-09-23 14:30:04
Message-ID: 20160923143004.10493.84876 () mimi ! kde ! org
[Download RAW message or body]
--===============7838373578839197407==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 23, 2016, 3:16 a.m., Boudhayan Gupta wrote:
> > Diff looks sane to me, and the feature seems useful in theory.
> >
> > Will this require a reindexing? Seems to me from previous comments made by vHanda \
> > that there's a schema change involved?
Yes. The full tag is stored in its own prefix.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128664/#review99481
-----------------------------------------------------------
On Sept. 22, 2016, 6:41 p.m., James Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128664/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 6:41 p.m.)
>
>
> Review request for Baloo and Boudhayan Gupta.
>
>
> Bugs: 334615
> http://bugs.kde.org/show_bug.cgi?id=334615
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Index and query each tag as a single full term for generating recursed search \
> results. Represent nested tags as recursed items in the Tags:// KIO Slave.
>
> Diffs
> -----
>
> autotests/unit/file/basicindexingqueuetest.cpp \
> 71689b22f03688b54fc292746afbff672a5a63e8 src/file/basicindexingjob.cpp \
> 88bb59a01e5592abb74b1ab345bfc6765d35db57 src/kioslaves/tags/kio_tags.cpp \
> de2e6d71945632e23a85f831878b4c431360731c src/lib/searchstore.cpp \
> 060a4fd795ab858eb84526f93f827d09ee85db7c
> Diff: https://git.reviewboard.kde.org/r/128664/diff/
>
>
> Testing
> -------
>
> Compile, run
>
>
> Thanks,
>
> James Smith
>
>
--===============7838373578839197407==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128664/">https://git.reviewboard.kde.org/r/128664/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 23rd, 2016, 3:16 a.m. MDT, \
<b>Boudhayan Gupta</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Diff looks sane to me, and the feature \
seems useful in theory.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Will this require a reindexing? Seems \
to me from previous comments made by vHanda that there's a schema change \
involved?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes. \
The full tag is stored in its own prefix.</p></pre> <br />
<p>- James</p>
<br />
<p>On September 22nd, 2016, 6:41 p.m. MDT, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Boudhayan Gupta.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2016, 6:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334615">334615</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Index and query each tag as a single full term for \
generating recursed search results. Represent nested tags as recursed items in the \
Tags:// KIO Slave.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/unit/file/basicindexingqueuetest.cpp <span style="color: \
grey">(71689b22f03688b54fc292746afbff672a5a63e8)</span></li>
<li>src/file/basicindexingjob.cpp <span style="color: \
grey">(88bb59a01e5592abb74b1ab345bfc6765d35db57)</span></li>
<li>src/kioslaves/tags/kio_tags.cpp <span style="color: \
grey">(de2e6d71945632e23a85f831878b4c431360731c)</span></li>
<li>src/lib/searchstore.cpp <span style="color: \
grey">(060a4fd795ab858eb84526f93f827d09ee85db7c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128664/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7838373578839197407==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic