[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 128665: Nested tags for Baloo Widgets
From: Vishesh Handa <me () vhanda ! in>
Date: 2016-09-04 9:53:27
Message-ID: 20160904095327.21849.29891 () mimi ! kde ! org
[Download RAW message or body]
--===============6912251944266511387==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 19, 2016, 8:52 a.m., Vishesh Handa wrote:
> > Could you please attach some screenshots of the before and after?
>
> James Smith wrote:
> I don't think it's really necessary, the existing indexed tag was erased if a tag \
> higher up was selected, or an expanded first-level indexed tag became unexpanded \
> when erasing an unsaved new tag beyond the last item of the indexed tag.
I cannot visaulize how this looks by just reading at the code. Please add images. \
Otherwise I need to compile this code and try it out manually.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128665/#review98495
-----------------------------------------------------------
On Aug. 19, 2016, 12:05 a.m., James Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128665/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2016, 12:05 a.m.)
>
>
> Review request for Baloo.
>
>
> Bugs: 334615
> http://bugs.kde.org/show_bug.cgi?id=334615
>
>
> Repository: baloo-widgets
>
>
> Description
> -------
>
> Info pane tags are shortened to their last element, with the full tag shown in each \
> tag's tooltip. The tag selector box allows for creating and selecting nested tags.
>
> Diffs
> -----
>
> src/kedittagsdialog.cpp 1778d53
> src/kedittagsdialog_p.h 3c4de19
> src/tagcheckbox.cpp 8273a7f
>
> Diff: https://git.reviewboard.kde.org/r/128665/diff/
>
>
> Testing
> -------
>
> Compile, run
>
>
> Thanks,
>
> James Smith
>
>
--===============6912251944266511387==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128665/">https://git.reviewboard.kde.org/r/128665/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 19th, 2016, 8:52 a.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Could you please attach some screenshots of the before \
and after?</p></pre> </blockquote>
<p>On August 20th, 2016, 10:57 p.m. UTC, <b>James Smith</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think it's really necessary, the existing indexed tag was erased if a tag \
higher up was selected, or an expanded first-level indexed tag became unexpanded when \
erasing an unsaved new tag beyond the last item of the indexed tag.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
cannot visaulize how this looks by just reading at the code. Please add images. \
Otherwise I need to compile this code and try it out manually.</p></pre> <br />
<p>- Vishesh</p>
<br />
<p>On August 19th, 2016, 12:05 a.m. UTC, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2016, 12:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334615">334615</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo-widgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Info pane tags are shortened to their last element, \
with the full tag shown in each tag's tooltip. The tag selector box allows for \
creating and selecting nested tags.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kedittagsdialog.cpp <span style="color: grey">(1778d53)</span></li>
<li>src/kedittagsdialog_p.h <span style="color: grey">(3c4de19)</span></li>
<li>src/tagcheckbox.cpp <span style="color: grey">(8273a7f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128665/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6912251944266511387==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic