--===============4803425387464128454== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/#review98859 ----------------------------------------------------------- This breaks the default behavior of searching and makes it hard to reason what is going on. Eg - `baloosearch 'tag:Death Fire'` and `baloosearch tag:Death Fire` now yield different results since "Fire" is considered part of the tag in the first query. I would rather not ship this. - Vishesh Handa On Aug. 24, 2016, 3:26 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128738/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 3:26 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add quotation marks surrounding the search term for all searches matching operator = or :. > > > Diffs > ----- > > src/tools/baloosearch/main.cpp 8fabdbb > > Diff: https://git.reviewboard.kde.org/r/128738/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > > --===============4803425387464128454== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128738/

This breaks the default behavior of searching and makes it hard to reason what is going on.

Eg - baloosearch 'tag:Death Fire' and baloosearch tag:Death Fire now yield different results since "Fire" is considered part of the tag in the first query.

I would rather not ship this.

- Vishesh Handa

On August 24th, 2016, 3:26 p.m. UTC, James Smith wrote:

Review request for Baloo and Vishesh Handa.

By James Smith.

Updated Aug. 24, 2016, 3:26 p.m.

Repository: baloo

Description

Add quotation marks surrounding the search term for all searches matching operator = or :.

Testing

Compile, run.

Diffs

src/tools/baloosearch/main.cpp (8fabdbb)

View Diff

--===============4803425387464128454==--