'Review Request 128554: Check for xattr during config step, otherwise the build might fail (if xattr.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Review Request 128554: Check for xattr during config step, otherwise the build might fail (if xattr.
From:       Johan Ouwerkerk <jm.ouwerkerk () gmail ! com>
Date:       2016-07-29 17:42:52
Message-ID: 20160729174252.21373.65315 () mimi ! kde ! org
[Download RAW message or body]

--===============2858080746142998089==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128554/
-----------------------------------------------------------

Review request for Baloo.


Repository: kfilemetadata


Description
-------

Check for xattr during config step, otherwise the build might fail (if xattr.h is \
missing). Missing xattr should now trigger an error message to prompt the user into \
installing libattr + development packages.


Diffs
-----

  CMakeLists.txt 4ec8eebe54fa8220c30930efffd8e76fd5eb0695 
  cmake/FindXattr.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128554/diff/


Testing
-------


Thanks,

Johan Ouwerkerk


--===============2858080746142998089==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128554/">https://git.reviewboard.kde.org/r/128554/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Johan Ouwerkerk.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Check for xattr during config step, otherwise the build might fail (if \
xattr.h is missing). Missing xattr should now trigger an error message to prompt the \
user into installing libattr + development packages.</pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(4ec8eebe54fa8220c30930efffd8e76fd5eb0695)</span></li>

 <li>cmake/FindXattr.cmake <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128554/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============2858080746142998089==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic