--===============2671576120602545953== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128189/#review96569 ----------------------------------------------------------- Ship it! It's so strange that no matter what we still keep getting corrupted data. If possible, it would be nice if you could save cola's baloo db and try to diagnose exactly what got corrupted. Or if it is small enough we can save it (after removing personal data) and use it as a test case. - Vishesh Handa On June 14, 2016, 8:32 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128189/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 8:32 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > We can have cases when deleting a directory from DocumentUrlDB when we have some children stored under it which actually don't exist on the file system. This can happen when the dir is being removed from DB because it doesn't exist on the filesystem. > > We do need to work on cleaning up the DB when we encounter such behaviour or even better figure out why it is happening and preventing it from happening. > > > Diffs > ----- > > src/engine/documenturldb.h 9bd5bb5 > > Diff: https://git.reviewboard.kde.org/r/128189/diff/ > > > Testing > ------- > > Fixed crash on CoLa's laptop. > > > Thanks, > > Pinak Ahuja > > --===============2671576120602545953== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128189/

Ship it!

It's so strange that no matter what we still keep getting corrupted data.

If possible, it would be nice if you could save cola's baloo db and try to diagnose exactly what got corrupted. Or if it is small enough we can save it (after removing personal data) and use it as a test case.

- Vishesh Handa

On June 14th, 2016, 8:32 p.m. UTC, Pinak Ahuja wrote:

Review request for Baloo.

By Pinak Ahuja.

Updated June 14, 2016, 8:32 p.m.

Repository: baloo

Description

We can have cases when deleting a directory from DocumentUrlDB when we have some children stored under it which actually don't exist on the file system. This can happen when the dir is being removed from DB because it doesn't exist on the filesystem.

We do need to work on cleaning up the DB when we encounter such behaviour or even better figure out why it is happening and preventing it from happening.

Testing

Fixed crash on CoLa's laptop.

Diffs

src/engine/documenturldb.h (9bd5bb5)

--===============2671576120602545953==--