'Re: Review Request 126227: Fix incomplete or duplicate search result with mtime'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 126227: Fix incomplete or duplicate search result with mtime
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2015-12-14 23:34:19
Message-ID: 20151214233419.7434.9885 () mimi ! kde ! org
[Download RAW message or body]

--===============4021099569924903989==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126227/#review89508
-----------------------------------------------------------

Ship it!

- Vishesh Handa

On Dec. 6, 2015, 6:03 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126227/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2015, 6:03 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Test with
> - baloosearch 'modified=>...' -d $HOME
> - baloosearch 'modified=>...'
> 
> This two queries should return same result since I only index home folder. But they \
> are not, because result from mtimedb is not sorted. 
> In some other rare case (On my machine, regularly happens to torrent downloaded \
> files), it could also return duplicate result. not sure if this should be \
> considered as a indexer bug. 
> Sort and remove duplication from the result in VectorPostingIterator when \
> requesting first result with next(). 
> 
> Diffs
> -----
> 
> autotests/unit/engine/mtimedbtest.cpp e38022d 
> src/engine/mtimedb.h 1dc1cb9 
> src/engine/mtimedb.cpp f7283b5 
> 
> Diff: https://git.reviewboard.kde.org/r/126227/diff/
> 
> 
> Testing
> -------
> 
> No more duplicate result or missing result.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

--===============4021099569924903989==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126227/">https://git.reviewboard.kde.org/r/126227/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- Vishesh Handa</p>

<br />
<p>On December 6th, 2015, 6:03 p.m. UTC, Xuetian Weng wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Dec. 6, 2015, 6:03 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">Test with
- baloosearch 'modified=&gt;...' -d $HOME
- baloosearch 'modified=&gt;...'</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This two queries should return same result since I \
only index home folder. But they are not, because result from mtimedb is not \
sorted.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In some other rare case (On my machine, regularly \
happens to torrent downloaded files), it could also return duplicate result. not sure \
if this should be considered as a indexer bug.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sort \
and remove duplication from the result in VectorPostingIterator when requesting first \
result with next().</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">No more duplicate result or missing result.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/unit/engine/mtimedbtest.cpp <span style="color: \
grey">(e38022d)</span></li>

 <li>src/engine/mtimedb.h <span style="color: grey">(1dc1cb9)</span></li>

 <li>src/engine/mtimedb.cpp <span style="color: grey">(f7283b5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126227/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4021099569924903989==--

[Attachment #3 (text/plain)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 