[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-12-14 23:33:26
Message-ID: 20151214233326.7434.50519 () mimi ! kde ! org
[Download RAW message or body]
--===============3569763783873655433==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote:
> > runners/baloo/baloosearchrunner.cpp, line 165
> > <https://git.reviewboard.kde.org/r/125369/diff/1/?file=405159#file405159line165>
> >
> > Have a look at basicindexingjob.txt. We define that all Presentation and \
> > Spreadsheets are also Documents.
> > For text, we specifically don't do that, as then we get source code as Documents. \
> > Maybe we can make another category caleld "Source Code" or something. I'm not \
> > sure, but just combining the two doesn't seem correct.
> > Maybe others can chime in?
>
> Igor Poboiko wrote:
> Dammit, my fault. Sorry for the noise. I just noticed that sometimes KRunner don't \
> look for presentations, so I thought the issue was here. And when I fixed it, it \
> worked. But it seems like the problem is with indexing; sometimes mimetype is not \
> determined correctly. And it's not always reproducible. But that's another issue.
> # balooctl index test.ppt
> Indexing /home/eol/test.ppt
> -- indexing "/home/eol/test.ppt" mimetype "application/x-ole-storage"
> File(s) indexed
> # mimetype test.ppt
> application/vnd.ms-powerpoint
>
> Regarding indexing of text files: I thought the issue was just due to performance \
> of indexing; but now it doesn't index large text-files. I mean, e.g. I have a lot \
> of plain-text documents (which are not source codes, but are proper documents): \
> those are mostly LaTeX files or just .txt files with some notes. I expected them to \
> pop up during search.
> Pinak Ahuja wrote:
> That would me mainly because we skip text files larger than 10 mb, have a look at \
> file/extractor/app.cpp Maybe we can experiment with a different limit. Mimetype \
> issue is something we should look into. I've seen audio files with .m4a extension \
> showing mimetype as video in the index.
> Igor Poboiko wrote:
> No-no, that wasn't the case. My .tex-files are much smaller (several KBs), and \
> "balooshow -x" shows that they are indexed properly. They just don't popup because \
> of its type ("T8 Ttext" in index).
> The limit solution looks perfectly fine for me. I mean, I don't write files of size \
> 10Mb+ by myself :) They are 99.99% are not documents but just some \
> machine-generated junk (log-files, or something like that), and I don't want it to \
> be indexed anyways. But small text files might be useful for me. Especially if they \
> are already indexed :)
> Talking about mimetypes: right, I had the same issue with mp4 audio-files too. But \
> it seems to be an upstream issue, mimetype handling is shared-mime-database and Qt \
> job...
> Vishesh Handa wrote:
> Ping? Can this be closed.
>
> Igor Poboiko wrote:
> It would be very useful for me if it would look for at least some of text files \
> (.tex and .lyx files, to be more specific). At least under some new category \
> ("Plain text files", etc). But that's clearly another issue, this can indeed be \
> closed.
Alright. I'm discarding this.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125369/#review85905
-----------------------------------------------------------
On Sept. 24, 2015, 7:18 a.m., Igor Poboiko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125369/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 7:18 a.m.)
>
>
> Review request for Baloo and Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Small usability improvement: since presentations, spreadsheets and text files are \
> also documents (at least, that's what I expect :) ), search for them in KRunner \
> when "documents" category is checked.
>
> Diffs
> -----
>
> runners/baloo/baloosearchrunner.cpp 0023a11
>
> Diff: https://git.reviewboard.kde.org/r/125369/diff/
>
>
> Testing
> -------
>
> It just works: now I am able to find my LaTeX-files, various presentations, etc \
> with KRunner.
>
> Thanks,
>
> Igor Poboiko
>
>
--===============3569763783873655433==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125369/">https://git.reviewboard.kde.org/r/125369/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 24th, 2015, 11:50 p.m. UTC, \
<b>Vishesh Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125369/diff/1/?file=405159#file405159line165" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/baloo/baloosearchrunner.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
SearchRunner::match(Plasma::RunnerContext& context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">165</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">matches</span> <span class="o"><<</span> <span \
class="n">match</span><span class="p">(</span><span class="n">context</span><span \
class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"Text"</span><span class="p">),</span> <span \
class="n">i18n</span><span class="p">(</span><span \
class="s">"Document"</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have \
a look at basicindexingjob.txt. We define that all Presentation and Spreadsheets are \
also Documents.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">For text, we specifically don't do \
that, as then we get source code as Documents. Maybe we can make another category \
caleld "Source Code" or something. I'm not sure, but just combining the two doesn't \
seem correct.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Maybe others can chime in?</p></pre> </blockquote>
<p>On September 25th, 2015, 7:16 a.m. UTC, <b>Igor Poboiko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Dammit, my fault. Sorry for the noise. I just noticed that sometimes \
KRunner don't look for presentations, so I thought the issue was here. And when I \
fixed it, it worked. But it seems like the problem is with indexing; sometimes \
mimetype is not determined correctly. And it's not always reproducible. But that's \
another issue.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"># balooctl index test.ppt \
Indexing /home/eol/test.ppt
-- indexing "/home/eol/test.ppt" mimetype \
"application/x-ole-storage" File(s) indexed
# mimetype test.ppt
application/vnd.ms-powerpoint
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regarding indexing of text files: I thought the issue \
was just due to performance of indexing; but now it doesn't index large text-files. I \
mean, e.g. I have a lot of plain-text documents (which are not source codes, but are \
proper documents): those are mostly LaTeX files or just .txt files with some notes. I \
expected them to pop up during search.</p></pre> </blockquote>
<p>On September 25th, 2015, 7:23 a.m. UTC, <b>Pinak Ahuja</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
would me mainly because we skip text files larger than 10 mb, have a look at \
file/extractor/app.cpp Maybe we can experiment with a different limit. Mimetype issue \
is something we should look into. I've seen audio files with .m4a extension showing \
mimetype as video in the index.</p></pre> </blockquote>
<p>On September 25th, 2015, 7:33 a.m. UTC, <b>Igor Poboiko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">No-no, that wasn't the case. My .tex-files are much smaller (several KBs), \
and "balooshow -x" shows that they are indexed properly. They just don't popup \
because of its type ("T8 Ttext" in index).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The limit solution \
looks perfectly fine for me. I mean, I don't write files of size 10Mb+ by myself :) \
They are 99.99% are not documents but just some machine-generated junk (log-files, or \
something like that), and I don't want it to be indexed anyways. But small text files \
might be useful for me. Especially if they are already indexed :)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Talking about mimetypes: right, I had the same issue with mp4 audio-files \
too. But it seems to be an upstream issue, mimetype handling is shared-mime-database \
and Qt job...</p></pre> </blockquote>
<p>On December 6th, 2015, 11:51 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping? \
Can this be closed.</p></pre> </blockquote>
<p>On December 6th, 2015, 4:35 p.m. UTC, <b>Igor Poboiko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
would be very useful for me if it would look for at least some of text files (.tex \
and .lyx files, to be more specific). At least under some new category ("Plain text \
files", etc). But that's clearly another issue, this can indeed be closed.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Alright. I'm discarding this.</p></pre> <br />
<p>- Vishesh</p>
<br />
<p>On September 24th, 2015, 7:18 a.m. UTC, Igor Poboiko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Plasma.</div>
<div>By Igor Poboiko.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2015, 7:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Small usability improvement: since presentations, \
spreadsheets and text files are also documents (at least, that's what I expect :) ), \
search for them in KRunner when "documents" category is checked.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It just works: now I am able to find my LaTeX-files, \
various presentations, etc with KRunner.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/baloo/baloosearchrunner.cpp <span style="color: \
grey">(0023a11)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125369/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3569763783873655433==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic