[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 126223: Fix date filter used by timeline:/
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-12-05 2:43:13
Message-ID: 20151205024313.29696.82544 () mimi ! kde ! org
[Download RAW message or body]
--===============8392458098532497470==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126223/#review89142
-----------------------------------------------------------
Ship it!
src/lib/searchstore.cpp (line 221)
<https://git.reviewboard.kde.org/r/126223/#comment61008>
I'm guessing I was trying to implement the case when you only specify the year + \
day and not the month, though that doesn't seem to make much sense to me.
- Vishesh Handa
On Dec. 2, 2015, 6:42 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126223/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 6:42 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> timeline:/ doesn't return correct result for month 1 or day 1, this is because date \
> filter always takes 1 as whole month or whole year. 0 should be used in such case.
>
> Diffs
> -----
>
> src/lib/searchstore.cpp 11fbd3f
>
> Diff: https://git.reviewboard.kde.org/r/126223/diff/
>
>
> Testing
> -------
>
> timeline://2015-12/2015-12-01 now returns correct result.
>
>
> Thanks,
>
> Xuetian Weng
>
>
--===============8392458098532497470==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126223/">https://git.reviewboard.kde.org/r/126223/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126223/diff/2/?file=420700#file420700line221" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/searchstore.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">PostingIterator* SearchStore::constructQuery(Transaction* tr, const Term& \
term)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">220</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">endDate</span><span class="p">.</span><span class="n">setDate</span><span \
class="p">(</span><span class="n">endDate</span><span class="p">.</span><span \
class="n">year</span><span class="p">(),</span> <span class="mi">12</span><span \
class="p">,</span> <span class="n"><span class="hl">endDate</span></span><span \
class="p"><span class="hl">.</span></span><span class="n"><span \
class="hl">day</span></span><span class="p"><span \
class="hl">()</span>);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">221</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">endDate</span><span class="p">.</span><span class="n">setDate</span><span \
class="p">(</span><span class="n">endDate</span><span class="p">.</span><span \
class="n">year</span><span class="p">(),</span> <span class="mi">12</span><span \
class="p">,</span> <span class="mi"><span class="hl">31</span></span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
guessing I was trying to implement the case when you only specify the year + day and \
not the month, though that doesn't seem to make much sense to me.</p></pre> </div>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On December 2nd, 2015, 6:42 p.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2015, 6:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">timeline:/ doesn't return correct result for month 1 \
or day 1, this is because date filter always takes 1 as whole month or whole year. 0 \
should be used in such case.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">timeline://2015-12/2015-12-01 now returns correct \
result.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/searchstore.cpp <span style="color: grey">(11fbd3f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126223/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8392458098532497470==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic