[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 126132: Better bitrate format in filemetadatawidget
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-11-24 10:53:36
Message-ID: 20151124105336.23104.50801 () mimi ! kde ! org
[Download RAW message or body]
--===============8322512166409873432==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126132/#review88752
-----------------------------------------------------------
Ship it!
src/widgetfactory.cpp (line 118)
<https://git.reviewboard.kde.org/r/126132/#comment60856>
Perhaps use QStringLiteral instead?
- Vishesh Handa
On Nov. 22, 2015, 2:26 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126132/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2015, 2:26 a.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: baloo-widgets
>
>
> Description
> -------
>
> Bitrate can be better formatted.
>
> Now it's either a strange double number (3.00594e+06), or a long integer (320000).
>
>
> Diffs
> -----
>
> src/widgetfactory.cpp 7151952
>
> Diff: https://git.reviewboard.kde.org/r/126132/diff/
>
>
> Testing
> -------
>
> Now 3.00594e+06 is displayed as 3.0 MB/s.
> 320000 is displayed as 320 kB/s.
>
>
> Thanks,
>
> Xuetian Weng
>
>
--===============8322512166409873432==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126132/">https://git.reviewboard.kde.org/r/126132/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126132/diff/1/?file=417629#file417629line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/widgetfactory.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QWidget* WidgetFactory::createWidget(const QString& prop, const QVariant& \
value, QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">117</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">prop</span> <span \
class="o">==</span> <span class="s">"duration"</span><span \
class="p">){</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">118</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">prop</span> <span class="o">==</span> <span \
class="n"><span class="hl">QLatin1Literal</span></span><span class="p"><span \
class="hl">(</span></span><span class="s">"duration"</span><span \
class="p">)<span class="hl">)</span></span><span class="hl"> </span><span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Perhaps use QStringLiteral instead?</p></pre> </div>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On November 22nd, 2015, 2:26 a.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2015, 2:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo-widgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Bitrate can be better formatted.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Now it's either a strange double number (3.00594e+06), or a long integer \
(320000).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now 3.00594e+06 is displayed as 3.0 MB/s. 320000 is \
displayed as 320 kB/s.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgetfactory.cpp <span style="color: grey">(7151952)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126132/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8322512166409873432==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic