[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 125818: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-10-27 20:37:05
Message-ID: 20151027203705.14097.14514 () mimi ! kde ! org
[Download RAW message or body]
--===============0937489470038713440==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125818/#review87546
-----------------------------------------------------------
Ship it!
Ship It!
- Vishesh Handa
On Oct. 27, 2015, 6:53 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125818/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 6:53 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> ...and use PATH_VARS to make the config file work with absolute paths.
>
> Two reasons to do this:
> - DBUS_INTERFACES_INSTALL_DIR is marked deprecated
> - By not hard-coding the packackage prefix, it's helpful on a multiarch
> layout where the prefix is /usr/${host} but arch-independent files
> should still be installed to /usr/share (i.e a level below the
> prefix).
>
>
> Diffs
> -----
>
> CMakeLists.txt 9f719667902cd13257b59113f1eb8bb0e8515d28
> KF5BalooConfig.cmake.in 08413efa29290c37dc501cc2ec1eb86d13218981
> src/dbus/CMakeLists.txt 44240ec643eef69f90b3832314ede46bca1820e5
> src/dbus/fake/CMakeLists.txt c9735b3d176c4a3c7ee995dac0aa83a3b715bf7c
>
> Diff: https://git.reviewboard.kde.org/r/125818/diff/
>
>
> Testing
> -------
>
> Successfully installed it with -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu \
> and -DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share
>
> Thanks,
>
> Heiko Becker
>
>
--===============0937489470038713440==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125818/">https://git.reviewboard.kde.org/r/125818/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Vishesh Handa</p>
<br />
<p>On October 27th, 2015, 6:53 p.m. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2015, 6:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">...and use PATH_VARS to make the config file work with absolute paths.
Two reasons to do this:
- DBUS_INTERFACES_INSTALL_DIR is marked deprecated
- By not hard-coding the packackage prefix, it's helpful on a multiarch
layout where the prefix is /usr/${host} but arch-independent files
should still be installed to /usr/share (i.e a level below the
prefix).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Successfully installed it with \
-DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu and \
-DCMAKE_INSTALL_FULL_DATAROOTDIR:PATH=/usr/share</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(9f719667902cd13257b59113f1eb8bb0e8515d28)</span></li>
<li>KF5BalooConfig.cmake.in <span style="color: \
grey">(08413efa29290c37dc501cc2ec1eb86d13218981)</span></li>
<li>src/dbus/CMakeLists.txt <span style="color: \
grey">(44240ec643eef69f90b3832314ede46bca1820e5)</span></li>
<li>src/dbus/fake/CMakeLists.txt <span style="color: \
grey">(c9735b3d176c4a3c7ee995dac0aa83a3b715bf7c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125818/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0937489470038713440==--
[Attachment #3 (text/plain)]
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic