'Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file w'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file w
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2015-10-27 18:48:04
Message-ID: 20151027184804.14097.90561 () mimi ! kde ! org
[Download RAW message or body]

--===============1425406307854427104==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125776/#review87541
-----------------------------------------------------------

Ship it!

> )

- Vishesh Handa

On Oct. 27, 2015, 6:35 p.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125776/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 6:35 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Since the inode remains same on moving, the fileId should be preserved. We can \
> simply check if the filePath in the db is same as the actual filePath to check if \
> file is moved and update the filePath if needed. This will also handle renames. 
> 
> Diffs
> -----
> 
> src/engine/documentoperations.h 6382e53 
> src/engine/transaction.h 2ae052e 
> src/engine/transaction.cpp f3c0f4c 
> src/engine/writetransaction.cpp ae27ad9 
> src/file/metadatamover.cpp adbd696 
> src/file/unindexedfileindexer.cpp 6873047 
> 
> Diff: https://git.reviewboard.kde.org/r/125776/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
> 

--===============1425406307854427104==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125776/">https://git.reviewboard.kde.org/r/125776/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">:)</p></pre>  <br />

<p>- Vishesh Handa</p>

<br />
<p>On October 27th, 2015, 6:35 p.m. UTC, Pinak Ahuja wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Pinak Ahuja.</div>

<p style="color: grey;"><i>Updated Oct. 27, 2015, 6:35 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since the inode remains same on moving, the fileId \
should be preserved. We can simply check if the filePath in the db is same as the \
actual filePath to check if file is moved and update the filePath if needed. This \
will also handle renames.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/engine/documentoperations.h <span style="color: grey">(6382e53)</span></li>

 <li>src/engine/transaction.h <span style="color: grey">(2ae052e)</span></li>

 <li>src/engine/transaction.cpp <span style="color: grey">(f3c0f4c)</span></li>

 <li>src/engine/writetransaction.cpp <span style="color: grey">(ae27ad9)</span></li>

 <li>src/file/metadatamover.cpp <span style="color: grey">(adbd696)</span></li>

 <li>src/file/unindexedfileindexer.cpp <span style="color: \
grey">(6873047)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125776/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1425406307854427104==--

[Attachment #3 (text/plain)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 